1044313 - Sublinks with in previous broken links are broken.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to settings
2. go to FFX Accounts
3. select create or sign in
4. select Terms of service
5. tap on either the first instance of Mozilla Privacy Policy or Mozilla Public License

Expected: link will take me somewhere
Actual: a whole lot of nothing happening

Note : This should have the fixes from bug 1037733?  I think?
Gaia      3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c0971104909
BuildID   20140725040205
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
Flame

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for a video.

Comment 2

[Joshua Mitchell (Inactive)]

Video Added - http://youtu.be/3pxPW76YB_o

taken from original build 

Device: Flame Master
Build ID: 20140725040205
Gaia: 3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko: 6c0971104909
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Jason Smith [:jsmith]]

Kevin - Can you provide a blocking triage analysis here?

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is no longer occurring the same way on 2.1. The page doesn't open at all on the sign in page which leads to a more serious issue. This is being written up as a different issue only for 2.1.

Nominating 2.0? because I'm pretty sure the user should always be able to read Mozilla's privacy policy. Seems like a possible legal issue here?

Adding qawanted to see if this occurs on 1.4.

Comment 5

[Dietrich Ayala (:dietrich)]

Triage discussed, and concluded that links should work in our Web operating system. Blocking+. Hoping that this is a regression...

Comment 6

[Rachel Pribble [:rpribble]]

Firefox Accounts is not an implemented feature in v1.4.

Environmental Variables:
Device: Flame 1.4
BuildID: 20140820000202
Gaia: 4f92950e6d96326785a249e8acb704da3647616b
Gecko: e1de5a959089
Version: 30.0 (1.4)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Other areas in Settings with clickable links are functioning as expected.

Comment 7

[Joshua Mitchell (Inactive)]

Not a regression if this was not implemented yet in 1.4 and is affected in 2.0

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The STR in comment 2 are different than the STR in the original report.

I am seeing different, but related issues: for me, it looks like the popup with the tos/pp gets loaded behind the fxa dialog. Looking now.

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

OK, there are actually 2 issues here.

One is that the tos/pp pages were getting opened *behind* the FxA popup. I've got a PR that fixes this, and will submit it in a moment.

The second bug is that some of the links within the tos/pp pages attempt to open in a new window via "target=_blank". It seems like those links are silently ignored here. I've opened a bug[1] for the server peeps to fix this. I don't know when their next deployment will be, but presumably it will be after the 2.0 code complete deadline, but many many months before 2.0 actually ships ;-). So, I guess QA will have to trust me on this part (or we can talk about it). Paging Jason for thoughts on this.

[1] https://github.com/mozilla/fxa-content-server/issues/1592

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 23231

Hi Alive,

This very small fix is a 2.0 blocker for FxA. Do you have time to review it?

Basically, if the user clicks on the "terms of service" link in the FxA dialog, I was opening an EntrySheet with the contents, but not making that EntrySheet a direct child of the #screen, so it was not getting the z-index.

Changing the parent node fixes this bug.

Cheers,

Jared

Comment 12

[Jason Smith [:jsmith]]

Sounds fine to me.

Comment 13

[Chris Karlof [:ckarlof]]

> The second bug is that some of the links within the tos/pp pages attempt to open in a new window via "target=_blank".

The FxA server *could* hack it after we draw them in, but the right place to fix this is in the legal repo. PR for that: https://github.com/mozilla/legal-docs/pull/179

Comment 14

[Chris Karlof [:ckarlof]]

https://github.com/mozilla/legal-docs/pull/179 was merged, so the changes should show up in the next FxA server release, which will be late this week/early next.

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

OK, my fix has landed, so the terms/privacy pages should display properly.

Marking closed as usual, but feel free to reopen or open a new bug to track the progress on the "some links failing to work" part of the bug, which will be verifiable later this week/next per comment 14.

Master: https://github.com/mozilla-b2g/gaia/commit/f792f294b2dd692598b66ccf0c7738f0bbf23950

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a51633e29a7826b6bf07cb1c5ad81b3217b9820a

Comment 17

[Paladin]

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
flame2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0

Comment 18

[Paladin]

Attachment: Verify_video.3gp