Closed
Bug 1044445
Opened 10 years ago
Closed 10 years ago
Collapse test-only moz.build files under content/ into ancestor moz.build files
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: poiru, Assigned: poiru)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
5.37 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
7.13 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1043963.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8463002 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8463003 -
Flags: review?(mh+mozilla)
Comment 3•10 years ago
|
||
Comment on attachment 8463002 [details] [diff] [review] Collapse test-only moz.build files under content/media/ into ancestor moz.build files Review of attachment 8463002 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/moz.build @@ -55,4 @@ > > -TEST_DIRS += [ > - 'test', > - 'gtest', I think you lost gtest
Comment 4•10 years ago
|
||
Comment on attachment 8463003 [details] [diff] [review] Collapse test-only moz.build files under content/ into ancestor moz.build files Review of attachment 8463003 [details] [diff] [review]: ----------------------------------------------------------------- Note this patch is bitrotted.
Attachment #8463003 -
Flags: review?(mh+mozilla) → review+
Comment 5•10 years ago
|
||
Comment on attachment 8463002 [details] [diff] [review] Collapse test-only moz.build files under content/media/ into ancestor moz.build files Review of attachment 8463002 [details] [diff] [review]: ----------------------------------------------------------------- Note this patch is bitrotted. ::: content/media/moz.build @@ -55,4 @@ > > -TEST_DIRS += [ > - 'test', > - 'gtest', What Ms2ger says.
Attachment #8463002 -
Flags: review?(mh+mozilla) → feedback+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5) > Comment on attachment 8463002 [details] [diff] [review] > Collapse test-only moz.build files under content/media/ into ancestor > moz.build files > > Review of attachment 8463002 [details] [diff] [review]: > ----------------------------------------------------------------- > > Note this patch is bitrotted. > > ::: content/media/moz.build > @@ -55,4 @@ > > > > -TEST_DIRS += [ > > - 'test', > > - 'gtest', > > What Ms2ger says. Fixed and rebased.
Attachment #8463002 -
Attachment is obsolete: true
Attachment #8464014 -
Flags: review?(mh+mozilla)
Updated•10 years ago
|
Attachment #8464014 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e835a9ab6bb https://hg.mozilla.org/integration/mozilla-inbound/rev/d84bafd55697 Try push: https://tbpl.mozilla.org/?tree=Try&rev=12c029f7de77
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e835a9ab6bb https://hg.mozilla.org/mozilla-central/rev/d84bafd55697
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e835a9ab6bb https://hg.mozilla.org/mozilla-central/rev/d84bafd55697
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•