Closed Bug 1044446 Opened 6 years ago Closed 6 years ago

Collapse test-only moz.build files under browser/ into ancestor moz.build files

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: poiru, Assigned: poiru)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Similar to bug 1043963.
Comment on attachment 8463005 [details] [diff] [review]
Collapse test-only moz.build files under browser/ into ancestor moz.build files

Review of attachment 8463005 [details] [diff] [review]:
-----------------------------------------------------------------

r+ conditional on fixing the misplaced chrome.ini.

Also, there are probably 20 days as nice as this in San Francisco per year. I advise you to go outside and explore. I'm only reviewing this because I'm looking for a reprieve from packing :)

::: browser/modules/moz.build
@@ +7,5 @@
> +DIRS += ['test/unit/social']
> +
> +BROWSER_CHROME_MANIFESTS += [
> +    'test/browser.ini',
> +    'test/chrome/chrome.ini'

chrome.ini should be in MOCHITEST_CHROME_MANIFESTS.
Attachment #8463005 - Flags: review?(ted) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> Also, there are probably 20 days as nice as this in San Francisco per year.
> I advise you to go outside and explore.

Yup, spent most of the day cruising on a bicycle :)

> ::: browser/modules/moz.build
> @@ +7,5 @@
> > +DIRS += ['test/unit/social']
> > +
> > +BROWSER_CHROME_MANIFESTS += [
> > +    'test/browser.ini',
> > +    'test/chrome/chrome.ini'
> 
> chrome.ini should be in MOCHITEST_CHROME_MANIFESTS.

Whoops!
https://hg.mozilla.org/mozilla-central/rev/cf141b96eb7e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 34 → mozilla34
You need to log in before you can comment on or make changes to this bug.