If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

GenerateRandomPassword() messes up emacs colors

VERIFIED WONTFIX

Status

()

Bugzilla
Bugzilla-General
--
trivial
VERIFIED WONTFIX
16 years ago
5 years ago

People

(Reporter: Jacob Steenhagen, Assigned: Jacob Steenhagen)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
The line that fills the @pwchars array contains ..., '$', ... which causes emacs
to mess up the coloring.  It look at that and thinks you are putting the value
of $' into the string (it's not smart enough to know what '' string can't
contain variables).  This causes the coloring of in string/other text to be
reversed for the next few lines (somehow it eventually corrects itself).  The
solution is to escape the $.
(Assignee)

Comment 1

16 years ago
Created attachment 53306 [details] [diff] [review]
escape the $
(Assignee)

Comment 2

16 years ago
-> me
Assignee: justdave → jake
Keywords: patch, review
(Assignee)

Updated

16 years ago
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.16
Comment on attachment 53306 [details] [diff] [review]
escape the $

$ isn't interpretted between single quotes.  So far so good.

\ is not interpretted either.

I just ran this code:

my $var = '\$';
print "$var\n";

The output was:
\$

Escaping the $ probably works, but try double-quotes around it instead.
Attachment #53306 - Flags: review-
Keywords: patch, review
(Assignee)

Comment 4

16 years ago
Tempted to WONTFIX unless someone else is really bothered by this.  Emacs
version 21.1 seems to have fixed this coloring bug. Of course, if you
can't/don't want to upgrade emacs, this will still be an issue.
We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18

Comment 6

14 years ago
No complaints in two years, patch has rotted slightly, emacs 21.1+ handles
coloring of the relevant lines just fine. Nearly everywhere has at least that
version of emacs (hell, even debian unstable... :). Wontfix.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WONTFIX
verif wontfix
Status: RESOLVED → VERIFIED
Target Milestone: Bugzilla 2.18 → ---
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.