1044665 - Hide toolbar when double-tapping to scroll in reader mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, enhancement)

Description

[Awad Mackie]

Following https://bugzilla.mozilla.org/show_bug.cgi?id=807990 landing, it would be good to hide the browser toolbar when double tapping to scroll page.

Comment 1

[Awad Mackie]

Attachment: double_tap_toolbar.patch

Patch split out from previous bug

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8463164 [details] [diff] [review]
double_tap_toolbar.patch

Review of attachment 8463164 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.

Comment 3

[Awad Mackie]

Thanks, mind pointing me towards how I can do a Try build before I add checkin-needed?

Comment 4

[Lucas Rocha (:lucasr)]

(In reply to Awad Mackie from comment #3)
> Thanks, mind pointing me towards how I can do a Try build before I add
> checkin-needed?

Have a look at https://wiki.mozilla.org/ReleaseEngineering/TryChooser#With_MQ

I assume you have commit access to Try? If not, I can run a Try build for you.

Comment 5

[Awad Mackie]

(In reply to Lucas Rocha (:lucasr) from comment #4)
> I assume you have commit access to Try? If not, I can run a Try build for
> you.

Ah, right. I don't actually, so if you don't mind!

Comment 6

[Lucas Rocha (:lucasr)]

Here you go: https://tbpl.mozilla.org/?tree=Try&rev=23cbc39de104

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/efc6e6534451

Thanks for the patch!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efc6e6534451