Closed Bug 1044667 Opened 9 years ago Closed 9 years ago

Fake GMPs needs to be accessible to gtest

Categories

(Firefox Build System :: General, defect)

29 Branch
x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1072024

People

(Reporter: cpearce, Unassigned)

References

(Blocks 1 open bug)

Details

A spin off from bug 1041347, we need to be able to create an arbitrary Gecko Media Plugin in a gtest.

We've been trying to use gtests for testing new media code, so that we can control the environment more to reduce the likelihood of orange.

So basically, we need a way to either set the MOZ_GMP_PATH to a known GMP's location on disk in the objdir, or somehow have a reliable/deterministic way of knowing that location so we can call GMPService::AddPluginDirectory() inside our gtest.
The former would be easy enough to do in the Python harness:
http://mxr.mozilla.org/mozilla-central/source/testing/gtest/rungtests.py

If you don't have a scenario where you need to test the absence of a GMP, that's probably the simplest solution.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> The former would be easy enough to do in the Python harness:
> http://mxr.mozilla.org/mozilla-central/source/testing/gtest/rungtests.py
> 
> If you don't have a scenario where you need to test the absence of a GMP,
> that's probably the simplest solution.

That works for |make check|, but |mach gtest| doesn't touch that script at all and doesn't seem to know where the XRE path should be. Any ideas there?
Flags: needinfo?(ted)
The right fix is to make |mach gtest| call through that same script. For a band-aid fix you could just put the same code in the mach command:
http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#609
Flags: needinfo?(ted)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.