1044713 - Parse MP4 Header until we reach 'mdat' atom

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

The existing MP4 parser metadata parsing is too sensitive to the order and presence of top level atoms. Change it so that it continues parsing until we hit the 'mdat' atom.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Modify MP4 metadata parser to make it less sensitive to atom ordering

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8463184 [details] [diff] [review]
Modify MP4 metadata parser to make it less sensitive to atom ordering

Review of attachment 8463184 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +493,3 @@
>          }
> +        char chunk[5];
> +        MakeFourCCString(chunk_type, chunk);

|chunk| is unused.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d34f40594ca

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d34f40594ca