104480 - EqualsIgnoreCase(nsAutoString(foo)) is bad and should die

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

There seem to be a number of occurences of this pattern in the tree.  We should
kill them off.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch. There aren't that many, actually.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Alec, jag, would you review?  The change to
intl/locale/src/mac/nsDateTimeFormatMac.cpp may require adding unicharutil to
the mac build magic; the xml already contains it, but someone who can build mac
should check....

Comment 3

[jag (Peter Annema)]

Comment on attachment 64706 [details] [diff] [review]
Patch.  There aren't that many, actually.

sr=jag, but your indentation is off in a few places (or are you trying to stay
within 80 chars?)

Comment 4

[Boris Zbarsky [:bzbarsky]]

no, those files just use tabs for indentation for all their code and I used
spaced for mine, as usual.   Will fix before checking in.

Comment 5

[Alec Flett]

Comment on attachment 64706 [details] [diff] [review]
Patch.  There aren't that many, actually.

thanks for catching that - yeah, and please fix the indentation - if you can't
fit without 80 cols, either rearrange the line again, or  let the line
overflow, but don't short-indent the line.

r=alecf with the indentation fixes

Comment 6

[jag (Peter Annema)]

alec, could you do a quick build test on your mac?

Comment 7

[Alec Flett]

ok, but it will take a while. (haven't built on my mac in a few days!)

Comment 8

[Boris Zbarsky [:bzbarsky]]

pinkerton built and it builds fine.  Checked in.