104493 - questionable dead code in NativeRegExp.java

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Brian D. Carlstrom]

We have a tool that looks for a scary noop case of assigning an instance field 
to itself. this usually comes from a constructor that assigns a argument to a 
instance field with the same name and then later the argument changes name. we 
ran our tool on all of our classes we have in our classpath here and found this 
problem in your code.

rhino1_5R2/src/org/mozilla/javascript/regexp/NativeRegExp.java line 159 it has:
        this.flags = flags;

This seems to be a bad cut and paste from the CompilerState constructor on line 
2155. or has some initialization that used to work been lost?

Comment 1

[Phil Schwartau]

cc'ing Roger - 

Comment 2

[Norris Boyd]

Fixed-- The value of flags is computed earlier in the method, so I believe
it is safe just to remove the assignment.

Thanks for finding this.

Comment 3

[Phil Schwartau]

Marking Verified - 

Comment 4

[Igor Bukanov]

Targeting as resolved against 1.5R3