Closed
Bug 1044973
Opened 10 years ago
Closed 10 years ago
Avoid storing None in the |unexpected| array in machformatter.py
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
In the case of an unexpected pass, there will be no |message| field in the data, which will lead to a None message in the tuple. This will trip up the "".join() call in test_end.
Attachment #8463303 -
Flags: review?(ahalberstadt)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8463303 [details] [diff] [review] Avoid storing None in the |unexpected| array in machformatter.py Review of attachment 8463303 [details] [diff] [review]: ----------------------------------------------------------------- Lgtm, though for future reference you should probably flag :jgraham or :chmanchester for review in structured log bugs
Attachment #8463303 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c99a02fcaca
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c99a02fcaca
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•