Closed Bug 1044999 Opened 9 years ago Closed 9 years ago

No L10n builds for Thunderbird for aurora/central due to client.py not allowing --skip-venkman

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(thunderbird33 fixed, thunderbird34 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 34.0
Tracking Flags:
Tracking Status
thunderbird33 --- fixed
thunderbird34 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

Support the old options
782 bytes, patch
Callek
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
Bug 1029513 removed the option for --skip-venkman, unfortunately, this breaks our l10n builds which are still using old automation, specifically:

http://hg.mozilla.org/build/buildbotcustom/annotate/ed6fd788088f/process/factory.py#l3331

I don't really want to remove that until after all our repositories stop supporting venkman, and adjusting the buildbot code for each merge is going to be awkward.

Hence, I'd rather just support backwards-compatibility for now.
Attachment #8463327 - Flags: review?(bugspam.Callek)
Comment on attachment 8463327 [details] [diff] [review]
Support the old options

Review of attachment 8463327 [details] [diff] [review]:
-----------------------------------------------------------------

r+ and approval+ if wanted.
Attachment #8463327 - Flags: review?(bugspam.Callek) → review+
Attachment #8463327 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/979611591901
https://hg.mozilla.org/releases/comm-aurora/rev/bf96a2fe5d86
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.