Closed Bug 1045021 Opened 10 years ago Closed 10 years ago

checkbox labels click tricky on touchscreen

Categories

(Core :: Layout: Form Controls, defect)

31 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1037941

People

(Reporter: olivier.godart, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140715214327

Steps to reproduce:

Using the testcase example, click on the label, but move the mouse slightly while you click (mousedown, move 5 pixels - stay in the label, mouseup). Doing this with a mouse isn't natural, but with a touchscreen, it's frequent that mouse moves slightly while clicking.


Actual results:

Checkbox doesn't change


Expected results:

Checkbox should change. It does when you do the same on the ckeckbox itself. The same click with move works also with anchors and buttons. It only fails with ckeckbox labels. (it also works with other browsers).
Hi, adding a few more details as I've been looking around.

It's a regression that was introduced by the fix of "Bug 382369 - Cannot select text in <label> associated with a <select>" in file "HTMLLabelElement.cpp".

In my opinion, selecting text inside a label is an unwanted feature or at least it's incoherent versus anchors and other clickable elements for which that feature doesn't exist.
However, if you find a way to allow selecting text, but also allow moving the mouse while clicking on an area with no text, that would be perfect.

Another, much more easy fix would be to increase that "CLICK_DISTANCE = 2" constant (10 would be better), or make it a settings parameter (but the default value should definitely be highter than 2).

Best regards,
Olivier
Summary: checkbox labels click behaviour → checkbox labels click tricky on touchscreen
Was it not supposed to be fixed by bug 608180?
Blocks: 382369
Component: Untriaged → Layout: Form Controls
Product: Firefox → Core
Keywords: testcase
(In reply to [:Aleksej] from comment #2)
> Was it not supposed to be fixed by bug 608180?

No, bug 608180 was a different issue, although it was introduced by the same patch.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: