Cannot use "thunderbird" as PROGRAM name, because it is already used in mail/components/search/mdimporter

RESOLVED FIXED in Thunderbird 34.0

Status

defect
--
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: iann_bugzilla)

Tracking

({dogfood, regression})

Trunk
Thunderbird 34.0
All
macOS

Thunderbird Tracking Flags

(thunderbird34 fixed)

Details

Attachments

(1 attachment)

This appears to be a regression on mac. The Thunderbird mdimporter - used for search, has a binary name of 'thunderbird', despite ending up in a different directory, this apparently conflicts with the main 'thunderbird' bin, according to the build system:

Cannot use "thunderbird" as PROGRAM name, because it is already used in mail/components/search/mdimporter

I guess we might be able to fix this by changing PROGRAM to be something else, and then changing CFBundleExecutable in the plist to reference the new name.
jcranmer attempted something already:
https://hg.mozilla.org/try-comm-central/rev/668afade99b3

That failed, but I suggested an alternative on irc, although I don't know if he saw it, so I'll repeat here:
you could apply the _MOZBUILD_EXTERNAL_VARIABLES trick to IS_COMPONENT instead, and set it to 1, so that rules.mk sets EXTRA_DSO_LDOPTS to -bundle for you
(In reply to Mike Hommey [:glandium] from comment #1)
> jcranmer attempted something already:
> https://hg.mozilla.org/try-comm-central/rev/668afade99b3
> 
> That failed, but I suggested an alternative on irc, although I don't know if
> he saw it, so I'll repeat here:
> you could apply the _MOZBUILD_EXTERNAL_VARIABLES trick to IS_COMPONENT
> instead, and set it to 1, so that rules.mk sets EXTRA_DSO_LDOPTS to -bundle
> for you

I did try that, but that got hung up on something else that I didn't try to debug.
Pushed to try server:
https://hg.mozilla.org/try-comm-central/rev/aa7edad6eac9
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #8465338 - Flags: review?(standard8)
Severity: normal → blocker
Keywords: dogfood, regression
Attachment #8465338 - Flags: review?(standard8) → review+
Comment on attachment 8465338 [details] [diff] [review]
Change the program name [Checked in: Comment 4]

https://hg.mozilla.org/comm-central/rev/9594eef26b92
Attachment #8465338 - Attachment description: Change the program name → Change the program name [Checked in: Comment 4]
Target Milestone: --- → Thunderbird 34.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.