TextRange.cpp failed to compile on VS2013: error C2872

RESOLVED FIXED in mozilla34

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Tetsuro Kato (tete), Assigned: Tetsuro Kato (tete))

Tracking

Trunk
mozilla34
x86_64
Windows 7
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8463419 [details] [diff] [review]
Patch for VS2013

Avoid compile error C2872 on VS2013.
Attachment #8463419 - Flags: review?(surkov.alexander)

Comment 1

3 years ago
Comment on attachment 8463419 [details] [diff] [review]
Patch for VS2013

Review of attachment 8463419 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed

::: accessible/base/TextRange.cpp
@@ -9,5 @@
>  #include "Accessible-inl.h"
>  #include "HyperTextAccessible.h"
>  #include "nsAccUtils.h"
>  
> -using namespace mozilla::a11y;

it seems "using namespace" is a common pattern in accessible module, why is this file special, would extra "using namespace mozilla" help here?
Attachment #8463419 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 2

3 years ago
(In reply to alexander :surkov from comment #1)
> ::: accessible/base/TextRange.cpp
> @@ -9,5 @@
> >  #include "Accessible-inl.h"
> >  #include "HyperTextAccessible.h"
> >  #include "nsAccUtils.h"
> >  
> > -using namespace mozilla::a11y;
> 
> it seems "using namespace" is a common pattern in accessible module, why is
> this file special, would extra "using namespace mozilla" help here?

I tried to insert "using namespace mozilla" before "using namespace mozilla::a11y", but VS2013 Update 2 also reported the following errors:

 0:05.63 e:\mozilla\mozilla_trunk-clone\accessible\base\TextRange.cpp(54) : error C2872: 'TextRange' : あいまいなシンボルです。
 0:05.63         'e:\mozilla\mozilla_trunk-clone\accessible\base\TextRange.h(46) の可能性があります : mozilla::a11y::TextRange'
 0:05.63         または 'e:\mozilla\mozilla_trunk-clone\FirefoxObjDebug\dist\include\mozilla/TextRange.h(136) : mozilla::TextRange'
 0:05.63 e:\mozilla\mozilla_trunk-clone\accessible\base\TextRange.cpp(63) : error C2872: 'TextRange' : あいまいなシンボルです。
 0:05.63         'e:\mozilla\mozilla_trunk-clone\accessible\base\TextRange.h(46) の可能性があります : mozilla::a11y::TextRange'
 0:05.63         または 'e:\mozilla\mozilla_trunk-clone\FirefoxObjDebug\dist\include\mozilla/TextRange.h(136) : mozilla::TextRange'
...
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/06bbea39061b
Assignee: nobody → tete009+bugzilla
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/06bbea39061b
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.