Closed Bug 1045117 Opened 11 years ago Closed 11 years ago

Create a qa-approval flag to track whether a signoff is needed before a patch is uplifted or landed

Categories

(bugzilla.mozilla.org :: Administration, task)

Production
task
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jsmith, Assigned: dkl)

Details

Create the flag "qa-approval" to track whether a signoff is needed before a patch is uplifted or landed. Note - the flag should allow someone to flag an individual down to provide the approval or not. Uplift Example: FMD patch lands on trunk. Dev wants uplift to 2.0. Release management desires a signoff before uplift, so they flag qa-approval? to the FMD tester to provide testing and signoff if testing passes for an uplift or not. Patch Landing Example: Vertical homescreen patch is put out for review, but desires QA testing before it lands. The dev flags qa-approval? to the vertical homescreen tester to provide testing and signoff if testing passes for a landing or not.
Which product(s) and optionally component(s) should this flag be visible? Also do we we need to make it where only permitted users are allowed to set the flag to +/-? More info: https://wiki.mozilla.org/BMO/Requesting_Changes#Flags dkl
Flags: needinfo?(jsmith)
(In reply to David Lawrence [:dkl] from comment #1) > Which product(s) and optionally component(s) should this flag be visible? * Firefox OS * Core > Also do we we need to make it where only permitted users are allowed to set > the flag to +/-? Yes. Anyone can set the ? mark flag. The +/- flag can only be set by FxOS QA team members: * tchung@mozilla.com * kglazko@mozilla.com * nhirata.bugzilla@gmail.com * jlorenzo@mozilla.com * gmealer@mozilla.com * npark@mozilla.com * jsmith@mozilla.com * martijn.martijn@gmail.com * stephen.donner@gmail.com * mbrandt@mozilla.com * zcampbell@mozilla.com * brhuang@mozilla.com * echang@mozilla.com * gchang@mozilla.com * edchen@mozilla.com * wachen@mozilla.com * whsu@mozilla.com * mlien@mozilla.com * hlu@mozilla.com * ashiue@mozilla.com * ctang@mozilla.com * atsai@mozilla.com * pyang@mozilla.com * fyen@mozilla.com
Flags: needinfo?(jsmith)
(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #2) > Yes. Anyone can set the ? mark flag. The +/- flag can only be set by FxOS QA > team members: > > * tchung@mozilla.com > * kglazko@mozilla.com > * nhirata.bugzilla@gmail.com > * jlorenzo@mozilla.com > * gmealer@mozilla.com > * npark@mozilla.com > * jsmith@mozilla.com > * martijn.martijn@gmail.com > * stephen.donner@gmail.com > * mbrandt@mozilla.com > * zcampbell@mozilla.com > * brhuang@mozilla.com > * echang@mozilla.com > * gchang@mozilla.com > * edchen@mozilla.com > * wachen@mozilla.com > * whsu@mozilla.com > * mlien@mozilla.com > * hlu@mozilla.com > * ashiue@mozilla.com > * ctang@mozilla.com > * atsai@mozilla.com > * pyang@mozilla.com > * fyen@mozilla.com I have created the qa-approval flag and a new group called 'qa-approvers' which I have made you an admin for. You can add the above members to the group by going to https://bugzilla.mozilla.org/editusers.cgi dkl
Assignee: nobody → dkl
Status: NEW → RESOLVED
Closed: 11 years ago
OS: Gonk (Firefox OS) → All
Hardware: ARM → All
Resolution: --- → FIXED
David - Could you allow the qa-approval flag to be set to particular QA as well? I saw that the flag currently does allow someone to flag ?/+/- for a patch, but it doesn't allow you to flag a particular individual down.
Flags: needinfo?(dkl)
(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #4) > David - Could you allow the qa-approval flag to be set to particular QA as > well? I saw that the flag currently does allow someone to flag ?/+/- for a > patch, but it doesn't allow you to flag a particular individual down. Yep. Should be good now. dkl
Flags: needinfo?(dkl)
You need to log in before you can comment on or make changes to this bug.