Closed
Bug 1045118
Opened 11 years ago
Closed 11 years ago
move install rules in browser/devtools/*/Makefile.in to moz.build
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
10.83 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
Various devtools Makefile.in's have |libs::| rules for installing .js and .jsm
files. The recent work in bug 1044162 has eliminated the need for those
rules. Let's remove them.
| Assignee | ||
Comment 1•11 years ago
|
||
Move everything to EXTRA_JS_MODULES. We need to be careful in projecteditor/
because INSTALL_TARGETS_FILES will happily install directories, not just
files. I admit that the new hotness here is...well, not all that hot.
The comments in projecteditor's Makefile.in appears to be sorely out of date,
so I have removed them as a casualty of this conversion.
(This patch needs bug 1044162's patches to be applied, if the dependency isn't
going to make that obvious.)
| Assignee | ||
Updated•11 years ago
|
Attachment #8463473 -
Flags: review?(mshal)
Comment 2•11 years ago
|
||
Comment on attachment 8463473 [details] [diff] [review]
move install rules in browser/devtools/*/Makefile.in to moz.build
Yeah, it would be nice if we could wildcard some of this stuff. Everything here looks fine for now though, but again I seem to be having trouble getting all these patches applied so this was just a manual review :(
Attachment #8463473 -
Flags: review?(mshal) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
This landed: http://hg.mozilla.org/mozilla-central/rev/d5718ab53065
I guess mcMerge missed this.
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•