Closed Bug 1045161 Opened 7 years ago Closed 7 years ago

remove remnants of mapping rules and frame attributes into style

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(2 files)

Bug 43178 removed the code that used the mappings of the rules and frame attributes into style, and also the code that computed the style, but didn't remove a few remaining bits.
I don't think this change should be observable to Web content anymore.
(If it is, we should probably fix that as a general issue.)
Attachment #8463530 - Flags: review?(bzbarsky)
Comment on attachment 8463530 [details] [diff] [review]
patch 1 - Stop implementing ParseAttribute for frame and rules (to parse them to enumerated values) since we no longer map them into style

r=me
Attachment #8463530 - Flags: review?(bzbarsky) → review+
Comment on attachment 8463531 [details] [diff] [review]
patch 2 - Remove write-only member variables of nsStyleTable

r=me
Attachment #8463531 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/0e4308c07967
https://hg.mozilla.org/mozilla-central/rev/1636ae2d7b53
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.