1045186 - [B2G][Ringtones] The user can not share ringtone through MMS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[pete siphantong [:Petes]]

Attachment: rm.txt

Description:
When the user attempts to share a ringtone through MMS, the sending/receiving gets a message 'There is a problem with the attached file and it cannot be downloaded.'

Setup Steps:
1) Flame device is set to 319mb

Repro Steps:
1) Update a Flame device to BuildID: 20140728000238
3) Go Settings > Sound
4) Tap Manage Ringtones > Tap any '...' ringtone options
5) Tap Share ringtone
6) Tap Messages 
7) Send out the MMS

Actual:
can not share ringtone through MMS

Expected:
share ringtone through MMS

Environmental Variables:
Device: Flame 2.0
Build ID: 20140728000238
Gaia: 0a864988f5dce7f9f3dea9609e8ef054679c30ff
Gecko: 2da96d621030
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0



Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13742/
See attached: screenshot, logcat

Comment 1

[pete siphantong [:Petes]]

Attachment: 2014-07-28-11-46-01.png

Comment 2

[pete siphantong [:Petes]]

This issue also reproduces on the Flame 2.1 (319mb), Buri 2.1, Flame 2.0(512mb), Buri 2.0, . Can not share ringtone through MMS


Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140728040209
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: a4dcfbebcb58
Version: 34.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140728073003
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: d77f6a96ff96
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0(512mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140728000238
Gaia: 0a864988f5dce7f9f3dea9609e8ef054679c30ff
Gecko: 2da96d621030
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140726063007
Gaia: 0a864988f5dce7f9f3dea9609e8ef054679c30ff
Gecko: 2da96d621030
Version: 32.0 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


_______________________________________________________________________________________________________________________

The issue does not reproduce on the Flame 1.4(319mb), Buri 1.4, and the Buri 1.3 because the share ringtone feature does not exist.

Flame 1.4(319MB)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140728063001
Gaia: eb3b185325901d4c04e2d43eb58d90835213bea9
Gecko: aae9112f1fc6
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140728063001
Gaia: eb3b185325901d4c04e2d43eb58d90835213bea9
Gecko: aae9112f1fc6
Version: 30.0 (1.4) MOZ
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Buri 1.3

Environmental Variables:
Device: Buri 1.3
Build ID: 20140725024005
Gaia: 23f55be856cef53c6604a6fe4aeb09061afbc897
Gecko: 9727017eabb9
Version: 28.0 (1.3)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Check your tracking flags based upon your branch checks comment.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Marcia, can you please look at this issue?  This looks like it could be a blocker.

Comment 5

[Marcia Knous [:marcia]]

[Blocking Requested - why for this release]: This functionality landed in Bug 960337 and should work according to the user story. 

When I tap on various ringtones, sometimes it gives me a message that the file is too large even before I get to the MMS panel. We should also clarify whether this is happening with the existing ringtones as well as ones that you bring in from other sources.

Comment 6

[Cody Roesch [:croesch]]

The following ringtones are too large to attach to MMS.
Disco Drive
Vamos La Elektro

Also when creating a custom ringtone, it is very easy to get this message that the file is too large.

Comment 7

[Hema Koka [:hema]]

Marcia: Is this only happening for large files? Or we simply cannot share any ringtone through MMS?

We have known issue with large attachments through MMS/SMS for other media files too. See Bugs https://bugzilla.mozilla.org/show_bug.cgi?id=949809 (music) and https://bugzilla.mozilla.org/show_bug.cgi?id=943976 (video).

Comment 8

[Sri Kasetti]

Marcia, Can you also check if the message/warning fires up before going to the MMS app?
It seems to me we should warn the user that the file is too large once he/she picks the option (Message)

Comment 9

[Marcia Knous [:marcia]]

Adding qawanted for further investigation. We should test all the default ringtones as well as any custom ringtones to see if the behavior is consistent. Also please note the question in Comment 8 about when the warning is firing.

Comment 10

[Cody Roesch [:croesch]]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #9)
> Adding qawanted for further investigation. We should test all the default
> ringtones as well as any custom ringtones to see if the behavior is
> consistent. Also please note the question in Comment 8 about when the
> warning is firing.

In comment 6, I tested all the default ringtones and I listed only the default ringtones that are too large to attach to MMS. Sorry that wasn't clear before.

As far as when the message fires, the MMS app opens and for a brief moment it looks like the user can attach the ringtone. Then the message about being too large is presented. So yes it seems a little misleading.

As far as Custom ringtones, a ringtone can be made from any audio file and there doesn't seem to be a way to cut music files down to fit so it's easy to not know what can and cannot be shared via mms. The "Too Large" message appears in the exact same way with custom ringtones as default ringtones as I've described above.

Hope this answered your questions.

Comment 11

[Jason Smith [:jsmith]]

Cody - I'm having trouble following your comment 10. Are you saying this bug only reproduces with ringtones too large to attach to a MMS? Or are you saying this can reproduce with other ringtones as well?

Comment 12

[Cody Roesch [:croesch]]

(In reply to Jason Smith [:jsmith] from comment #11)
> Cody - I'm having trouble following your comment 10. Are you saying this bug
> only reproduces with ringtones too large to attach to a MMS? Or are you
> saying this can reproduce with other ringtones as well?

Ok I think there was a little confusion on this bug. 

My comments have been answering Marcia's QAWanted questions about a separate message she was seeing when she tried to attach ringtones (default/custom) that were too large. So I listed out the default ringtones that said they were too large to attach even before they could be attached and sent. So my comments were not about the bug itself.

-----------------------------

Now I will provide information on the bug itself.

I have found that NO DEFAULT ringtones small enough to be attached, will successfully be sent to the recipient. When attempted to be sent, the error message "There is a problem with the attached file and it cannot be downloaded." will be seen. The receiving party will receive a blank message with no ringtone attached.

I WAS able to successfully take a custom ringtone I downloaded off the internet that was small enough to get attached. I was able to send this ringtone successfully to another user with no errors.

Comment 13

[Jason Smith [:jsmith]]

Blocking since this breaks a supported 2.0 use case with being able to share ringtones via MMS with any default ringtone.

Comment 14

[Jim Porter (:squib)]

Attachment: Fix it

David: Turns out bug 1032702 broke this, since the SMS app gets sad without a mimetype for the audio file. This fixes it, and as a bonus, I pass along the actual filename, which seems like the polite thing to do.

I guess I can write tests, but I'm not sure how much I can make the SMS app do when it's not on a real device...

Comment 15

[Jim Porter (:squib)]

Oh, and to triagers: note that bug 1032702 is a 1.4 bug, but this issue is only present in 2.0+.

Comment 16

[Hema Koka [:hema]]

Jim,

Can you route the review to Dominic please? David is ooo.

Thanks
Hema

Comment 17

[Jim Porter (:squib)]

Comment on attachment 8468119 [details] [review]
Fix it

Redirecting review, since David is out.

Comment 18

[Hema Koka [:hema]]

Dominic or David,

Please review Jim's patch today and move this forward!

Thanks
Hema

Comment 19

[David Flanagan [:djf]]

Comment on attachment 8468119 [details] [review]
Fix it

Code looks good to me. One nit noted on github that you might want to think about addressing before landing.  Note that I did not test the patch myself.

Comment 20

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/70463701f6ad148d74f28cb073d1197ff8f4ff4d

Comment 21

[ankit93040]

Hello Jim

Can we uplift these to v2.0 as well?

Thanks!

Comment 22

[Jim Porter (:squib)]

It's blocking-b2g:2.0+, so it should auto uplift.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/806d37a264743e04a3e1493136486f3e00124e1e