104523 - unnecessary calls to strlen in nsIOService::ParseFileURL

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Darin Fisher]

was just looking at the uses of nsIURLParser today, and noticed the following:

the strlen calls at the end of nsLocalFile::ParseURL are unnecessary, and can be
replaced by simply checking for a \0 byte in the first element of each string.

    // If any of the components are non-NULL but empty, free them
    if (*outHost && !nsCRT::strlen(*outHost))
        CRTFREEIF(*outHost);
    if (*outDirectory && !nsCRT::strlen(*outDirectory))
        CRTFREEIF(*outDirectory);
    if (*outFileBaseName && !nsCRT::strlen(*outFileBaseName))
        CRTFREEIF(*outFileBaseName);
    if (*outFileExtension && !nsCRT::strlen(*outFileExtension))
        CRTFREEIF(*outFileExtension);

eg.

    if (*outFileExtension && !**outFileExtension)

also, there is no need to call CRTFREEIF... the IF isn't necessary here.  why
don't we have a CRTFREE?

Comment 1

[Doug Turner (:dougt)]

conrad, alec, maybe you can look at this?  

Comment 2

[Alec Flett]

While I agree this is nasty, we're eventually getting rid of ParseURL from
nsLocalFile, so there is no necko dependency in xpcom. I'm marking this a
dependency of bug 100212, but I think that if we fix 100212 correctly, this bug
will automagically go away. But I'm leaving open just to be sure, 

Comment 3

[Alec Flett]

ok, I ended up moving ParseURL into nsIOService as ParseFileURL.. updating summary

Comment 4

[Alec Flett]

ok, so it looks like the code in question is gone, with darin's url parsing
optimizations a few weeks (months?) ago.. nothing to do now