Closed Bug 1045236 Opened 7 years ago Closed 7 years ago

contacts import screen has a strange notion of "TODAY", which includes yesterday

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: hola)

Details

Attachments

(2 files)

Attached image screenshot
The import screen in the settings part of the contacts app has a confused notion of "TODAY".  In particular, the attached screenshot, taken at 10:23am on July 26, shows "TODAY 6:51 PM" when I had last imported the previous day (July 25) at 6:51pm.

This should have said "yesterday".
Assignee: nobody → hola
The bug was produced because we only showed yesterday if more than 24 hours had elapsed. In my pull request, I change this system so that the comparison is made only between days, without comparing hours or smaller units. I also made a test which specifically tests for the case described in this bug.
Attachment #8475066 - Flags: review?(crdlc)
Comment on attachment 8475066 [details]
Palindromic pull request #23032

It works fine, 10x
Attachment #8475066 - Flags: review?(crdlc) → review+
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/e9eb46d30094ac25544fb7f3b891b0e53822802a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.