1045252 - [Flatfish] Power Saving Mode Notification Image Missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Nilay Binjola]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

1. Configure Battery Saver to start at 15% remaining battery using Settings App
2. Discharge Device
3. See Notification bar notification


Actual results:

There was a notification about the Power Saver. But the icon/image next to it was missing. Instead a "Missing" image was seen.


Expected results:

A proper Power Saver Icon/image should have been besides the notification text.

Comment 1

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Is the icon of power saving notification expected to be as same as system app default icon or we need another assets?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8464450 [details] [review]
Pull request

Please set UI review to fxosux and have a unit test if they really wanna system app icon to present power saving mode.

Comment 4

[Stephany Wilkes]

Hi Jenny - can you work with a visual designer on the asset question here? I'm not sure who should take this icon work. Thanks!

Comment 5

[Jenny Lee]

I was able to reproduce this problem on Flame too.
ni Helen to support the missing icon here ;)

Comment 6

[Helen Huang [:HHuang]]

Attachment: Power_saving_mode.zip

I've updated Power Saving Mode notification image in 4 sizes.

Comment 7

[Helen Huang [:HHuang]]

Attachment: Power_saving_mode.zip

Hi, the images has been modified, please update the files. 
Thank you!

Comment 8

[Sherman Chen [:chens] (inactive)]

Attachment: PowerSavingMode-Flame.png

Comment 9

[Sherman Chen [:chens] (inactive)]

Attachment: PowerSavingMode-Flatfish.png

Comment 10

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request 2

Update power saving mode icon, fixed screenshot in:
attachment 8466857 [details], attachment 8466858 [details]

Comment 11

[Helen Huang [:HHuang]]

Hi Sherman,
I checked the screenshots, looks like the @1 icon size should be 30x30 px? If yes, I need to modify the images... and update again.

Comment 12

[Sherman Chen [:chens] (inactive)]

Yep you are right, it's 30x30 px.

Comment 13

[Helen Huang [:HHuang]]

Attachment: Power_Saving_mode.zip

Sorry for the mistake...The images has been updated.

Comment 14

[Sherman Chen [:chens] (inactive)]

Thanks Helen, will you need screenshots for those updated icons?

Comment 15

[Helen Huang [:HHuang]]

Yes, it will be better if I can see the screenshots.
Maybe you can flag me again, thank you!

Comment 16

[Sherman Chen [:chens] (inactive)]

Attachment: PowerSavingMode-Flame.png

Comment 17

[Sherman Chen [:chens] (inactive)]

Attachment: PowerSavingMode-Flatfish.png

Comment 18

[Sherman Chen [:chens] (inactive)]

Screenshots updated, please refer to attachment 8466961 [details], attachment 8466962 [details]

Comment 19

[Helen Huang [:HHuang]]

The screenshots look good. Thanks for your help :)

Comment 20

[Sherman Chen [:chens] (inactive)]

Does this patch require ui-review+ to land, or I can proceed when CI is green?

Comment 21

[Stephany Wilkes]

This patch requires ui-review+. I will remove the review? flags set for UX. Only developers (usually the suggested reviewers in the Review field) take review? flags. Only UX team members take ui-review? flags.

Comment 22

[Stephany Wilkes]

Comment on attachment 8464450 [details] [review]
Pull request

Removing the review? flag for UX since it's covered by the ui-review? flag for Helen.

Comment 23

[Stephany Wilkes]

Comment on attachment 8466859 [details] [review]
Pull request 2

And updating the ui-review? to ui-review+ based on what Helen said in comment #19, and clearing her flag.

Comment 24

[Sherman Chen [:chens] (inactive)]

Merged to master: 
https://github.com/mozilla-b2g/gaia/commit/43ca7c2139cd417592cfc3a0530df8112e8f07d9