1045289 - nsXPComInit.cpp capitalizes XPCOM in a way unlike any other file

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

It would be nice if it was consistent and called nsXPCOMInit.cpp.

It looks like there are some include guards in nsXPCOMPrivate.h that could also be fixed up.

http://mxr.mozilla.org/mozilla-central/search?string=nsXPCom&filter=[Nn]sXPCom

Comment 1

[Andrew McCreight [:mccr8]]

A slightly more exhaustive list of possible places to change:
  http://mxr.mozilla.org/mozilla-central/search?string=XPCom&filter=[Xx]PCom

Comment 2

[poiru]

Attachment: Rename nsXPComInit.cpp to nsXPCOMInit.cpp

Comment 3

[poiru]

Attachment: Change uses of "XPCom" to "XPCOM"

Comment 4

[Benjamin Smedberg]

DON't LAND THIS! On Windows filesystems (and maybe mac), renaming a file in hg only by case will cause massic weird bustage.

If we're going to do this, I recommend naming it XPCOMInit.cpp so that it's a real rename.

Comment 5

[Andrew McCreight [:mccr8]]

Oops, I forgot about that.  There was even some discussion about having commit hooks to prevent that.

Comment 6

[Nathan Froyd [:froydnj]]

Fortunately this is one of those commit hooks that actually got written:

https://hg.mozilla.org/hgcustom/version-control-tools/file/3a3edd2df65e/hghooks/mozhghooks/prevent_case_only_renames.py

Comment 7

[poiru]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> DON't LAND THIS! On Windows filesystems (and maybe mac), renaming a file in
> hg only by case will cause massic weird bustage.

Yep, comment 2 was actually supposed to be accompanied with this comment:

I will split this into two commits (first rename to nsXPCOMInit_.cpp, then to nsXPCOMInit.cpp) due to case-insensitive filesystems.

Comment 8

[Benjamin Smedberg]

I don't think that's sufficient: Windows clients which update over both changes will still be confused. I really think you should just use XPCOMInit.cpp to avoid the problem.

Comment 9

[poiru]

https://hg.mozilla.org/integration/mozilla-inbound/rev/434f9192f7d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/d89e102c739e

Try push: https://tbpl.mozilla.org/?tree=Try&rev=321e96585805

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #8)
> I don't think that's sufficient: Windows clients which update over both
> changes will still be confused. I really think you should just use
> XPCOMInit.cpp to avoid the problem.

Done.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/434f9192f7d2
https://hg.mozilla.org/mozilla-central/rev/d89e102c739e