Closed Bug 1045289 Opened 5 years ago Closed 5 years ago

nsXPComInit.cpp capitalizes XPCOM in a way unlike any other file

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: mccr8, Assigned: poiru)

Details

Attachments

(2 files)

It would be nice if it was consistent and called nsXPCOMInit.cpp.

It looks like there are some include guards in nsXPCOMPrivate.h that could also be fixed up.

http://mxr.mozilla.org/mozilla-central/search?string=nsXPCom&filter=[Nn]sXPCom
A slightly more exhaustive list of possible places to change:
  http://mxr.mozilla.org/mozilla-central/search?string=XPCom&filter=[Xx]PCom
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Attachment #8492737 - Flags: review?(nfroyd)
Attachment #8492738 - Flags: review?(nfroyd)
Attachment #8492737 - Flags: review?(nfroyd) → review+
Attachment #8492738 - Flags: review?(nfroyd) → review+
DON't LAND THIS! On Windows filesystems (and maybe mac), renaming a file in hg only by case will cause massic weird bustage.

If we're going to do this, I recommend naming it XPCOMInit.cpp so that it's a real rename.
Oops, I forgot about that.  There was even some discussion about having commit hooks to prevent that.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> DON't LAND THIS! On Windows filesystems (and maybe mac), renaming a file in
> hg only by case will cause massic weird bustage.

Yep, comment 2 was actually supposed to be accompanied with this comment:

I will split this into two commits (first rename to nsXPCOMInit_.cpp, then to nsXPCOMInit.cpp) due to case-insensitive filesystems.
I don't think that's sufficient: Windows clients which update over both changes will still be confused. I really think you should just use XPCOMInit.cpp to avoid the problem.
https://hg.mozilla.org/integration/mozilla-inbound/rev/434f9192f7d2
https://hg.mozilla.org/integration/mozilla-inbound/rev/d89e102c739e

Try push: https://tbpl.mozilla.org/?tree=Try&rev=321e96585805

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #8)
> I don't think that's sufficient: Windows clients which update over both
> changes will still be confused. I really think you should just use
> XPCOMInit.cpp to avoid the problem.

Done.
https://hg.mozilla.org/mozilla-central/rev/434f9192f7d2
https://hg.mozilla.org/mozilla-central/rev/d89e102c739e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.