1045343 - Upsell is broken in the API

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: API, defect)

Description

[Andy McKay]

STR:
* make a paid app
* make a free app
* make the paid app an upsell of the free app
* the paid app should appear as an upsell of the free app

Example, you can see that its set in ES correctly as upsell:

[master] zamboni $ curl http://127.0.0.1:9200/apps/webapp/60 | python -m json.tool | grep app_slug -B 2 -A 10 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6115  100  6115    0     0  2185k      0 --:--:-- --:--:-- --:--:-- 2985k
    "_source": {
        "_boost": 4, 
        "app_slug": "test-app-giraffe3198", 
        "app_type": 1, 
        "author": "Gregory Koberger", 
        "banner_message_translations": [], 
        "banner_regions": [], 
        "bayesian_rating": 0.0, 
        "category": [
            "games", 
            "lifestyle"
        ], 
        "collection": [], 
--
--
        "type": 11, 
        "upsell": {
            "app_slug": "stopwatch", 
            "icon_url": "http://z.mozilla.dev/tmp/img/uploads/addon_icons/0/59-128.png?modified=decda5a9", 
            "id": 59, 
            "name": "Stopwatch", 
            "region_exclusions": [
                1, 
                4, 
                7, 
                10, 
                12, 
                13, 

[master] zamboni $ curl http://z.mozilla.dev/api/v1/apps/app/test-app-giraffe3198/ | python -m json.tool | grep upsell
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3613    0  3613    0     0  90801      0 --:--:-- --:--:-- --:--:-- 92641
    "upsell": false, 

Nothing is appearing in the details page to show the upsell.

You might also be able to spot this on apps that should have an upsell, for example:

https://marketplace.firefox.com/app/jack-and-beanstalk-jr-free/

Comment 1

[Andy McKay]

Oh, oh, regions. Its filtering that the app can actually be bought in the region the user requesting it.

Sorry for the noise.