The default bug view has changed. See this FAQ.

Don't schedule non-unified B2G hazard analysis builds

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [capacity])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
They serve no purpose. Let's kill with great prejudice and save some cycles.
(Assignee)

Comment 1

3 years ago
IIUC, we just need to remove this line:
http://hg.mozilla.org/build/buildbot-configs/annotate/4dd562b32ad0/mozilla/b2g_config.py#l1078

Its addition looks accidental to me given the lack of comments mentioning adding it on purpose in bug 898554.
Assignee: nobody → ryanvm
(Assignee)

Comment 2

3 years ago
Created attachment 8463718 [details] [diff] [review]
patch
Attachment #8463718 - Flags: review?(catlee)

Updated

3 years ago
Attachment #8463718 - Flags: review?(catlee) → review+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8463718 [details] [diff] [review]
patch

Thanks :)

https://hg.mozilla.org/build/buildbot-configs/rev/030baeecb9b3
Attachment #8463718 - Flags: checked-in+
something here is now in production
(Assignee)

Comment 5

3 years ago
And appears to be working on the periodic jobs that have kicked off.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
something(s) here went to production today
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #1)
> IIUC, we just need to remove this line:
> http://hg.mozilla.org/build/buildbot-configs/annotate/4dd562b32ad0/mozilla/
> b2g_config.py#l1078
> 
> Its addition looks accidental to me given the lack of comments mentioning
> adding it on purpose in bug 898554.

Not accidental, just misguided.

I just saw the boolean setting and thought that it meant whether you wanted the builds to be unified or not. Of those choices, nonunified seemed safer since the analysis reports filenames in its output, and I thought there was some chance that a unified build would end up using the outer "Unified_*.cpp" name instead of the actual file. I didn't think it would, but I had enough to deal with getting that landed.

Fortunately, I was wrong on both counts. It reports the desired filename in a unified build. (And that option does not do what I thought it did.) Sorry for the trouble.
You need to log in before you can comment on or make changes to this bug.