Closed Bug 1045415 Opened 10 years ago Closed 9 years ago

browser\themes\windows\content-contextmenu.svg: WARNING: no preprocessor directives found

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1109826

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file)

This fixes one build warning on the respective platforms.
Assignee: nobody → ehsan
Attachment #8463756 - Flags: review?(gps)
Attachment #8463756 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/b07c3d5ec540
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
See bug 1016405 comment 57. This issue is now back.
Component: Build Config → Theme
Flags: needinfo?(ehsan)
Product: Core → Firefox
Target Milestone: mozilla34 → ---
Target Milestone: --- → Firefox 34
(In reply to Dão Gottwald [:dao] from comment #4)
> See bug 1016405 comment 57. This issue is now back.

Hmm, not sure how to fix this.  Greg?

(Please feel free to back this out if needed.)
Flags: needinfo?(ehsan) → needinfo?(gps)
WTF. I guess we need to back out this patch and file a bug to fix whatever is wrong with symlinked SVG files (or fix the build system to work around it).
Flags: needinfo?(gps)
Blocks: 1051117
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: ehsan → nobody
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/3e0f03eae1c0
Assignee: nobody → ehsan
Target Milestone: Firefox 34 → ---
Still not interested in taking this.  :-)
Assignee: ehsan → nobody
Summary: Stop pretending that content-contextmenu.svg needs to be preprocessed → browser\themes\windows\content-contextmenu.svg: WARNING: no preprocessor directives found
This probably should be duped forward to bug 1109826, which landed recently to fix this in a bunch of places (including the place that this bug was originally fixing, before it was backed out).

(And the issue that caused this to back out seems like it may have been fixed, as described in bug 1051117 comment 25 & bug 1051117 comment 27.)
Status: REOPENED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: