1045417 - Event attendee with a comma in display name gets splitted in two attendees

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Jocelyn Viau]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

1. Have a contact in your address book that has a comma in the display name such as "Smith, John" with an email address (I will use [e-mail] here)
2. Create an event
3. Add attendees
4. As the first attendee, start typing the name of the contact mentionned at step 1.
5. Select the suggested contact (the one at step 1)



Actual results:

Two attendees are added to the event:
First attendee: Smith (with no email address)
Second attendee: John <[e-mail]>


Expected results:

There should be only one attendee:
Smith, John <[e-mail]>

Comment 1

[Decathlon]

Do you insert the two names separated with comma between double quotes when you edit the attendees dialog:

  "Smith, John" <[e-mail]>

It should work fine in this case, at least, it works for me with LG 3.3.

Comment 2

[Jocelyn Viau]

When I start typing the name of the first attendee, suggestions from my address book automatically appear. If I click on one, then the attendee is immediately splitted in two lines. Strangely, when I do that, the name is not enclosed in quotes like in your example.

FYI, I am using the French version of Thunderbird and Lightning, would that make a difference?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This is one of the issues we should be looking into for 3.3.1, Thunderbird wants to fix autocomplete issues for their 31.1.0 too.

Comment 5

[[:MakeMyDay]]

Attachment: SplitAddressListCorrectly-V1.diff

This one should take care.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8466800 [details] [diff] [review]
SplitAddressListCorrectly-V1.diff

Review of attachment 8466800 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
@@ +1055,5 @@
>            if (element.value.contains(",")) {
>                let strippedAddresses = element.value.replace(/.* >> /, "");
> +              let addresses = MailServices.headerParser.makeFromDisplayAddress(strippedAddresses);
> +              element.value = parseHeaderValue(addresses[0]);
> +              

Some whitespaces snuck in here.

Comment 7

[[:MakeMyDay]]

Attachment: SplitAddressListCorrectly-V2.diff

Updated patch with whitespaces removed.

Comment 8

[[:MakeMyDay]]

Do we want this also to be applied on aurora and beta beside release branch?

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushing so this can get picked up by the release builds:

https://hg.mozilla.org/releases/comm-esr31/rev/8317f9ef0d98

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/comm-central/rev/078e78571a92
https://hg.mozilla.org/releases/comm-aurora/rev/a032736616b7
https://hg.mozilla.org/releases/comm-beta/rev/fe7fc7bc40bf

This patch will not be in 3.4, but given its not a major release and the cycle is long gone, I'm not going to fix it there.