1045484 - TOOL_DIRS, TEST_TOOL_DIRS and PARALLEL_DIRS are no more

Status: RESOLVED DUPLICATE of bug 1044460

(MailNews Core :: Build Config, defect)

Description

[Philip Chee]

https://groups.google.com/d/topic/mozilla.dev.platform/Upub4yBYAYw/discussion
Hi,

I'd like to inform you today that choosing the right variable when
adding a new directory to the tree just got a lot easier with the
landing of bug 1043802 and bug 1043820 (on mozilla-inbound only at
the moment). Before, you had to choose from:
 - DIRS
 - PARALLEL_DIRS
 - TEST_DIRS
 - TOOL_DIRS
 - TEST_TOOL_DIRS

The choice is now reduced to:
 - DIRS
 - TEST_DIRS

The distinction that existed with PARALLEL_DIRS, TOOL_DIRS and
TEST_TOOL_DIRS are now irrelevant.

Cheers,

Mike

Comment 1

[Philip Chee]

Attachment: WIP Patch v0.1

What I have so far. Can't test because of other build config problems.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8464221 [details] [diff] [review]
WIP Patch v0.1

Review of attachment 8464221 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/moz.build
@@ +8,2 @@
>  if CONFIG['OS_ARCH'] == 'WINNT':
>      DIRS += ['installer/windows']

I don't know if the order is still relevant, but if it is, I would keep this at the end after 'app'.

Comment 4

[Sladky Vladimir]

Attachment: Error PARALLEL_DIRS Please use the DIRS variable instead.

I now canot compile - see please errors in attchment "log.txt"

Comment 5

[Florian Quèze [:florian]]

The patch here seems to be included in the latest version of the patch in bug 1044460.

Comment 6

[Philip Chee]

(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> The patch here seems to be included in the latest version of the patch in
> bug 1044460.
Marking as DUPLICATE

Comment 7

[Ian Neal]

Comment on attachment 8464221 [details] [diff] [review]
WIP Patch v0.1

As mentioned on IRC, I had most of this in a local patch, but thanks. I took onboard the comment mentioned here too.