Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: pmoore, Assigned: pmoore)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
From IRC:

mikeperry
08:31:02 is this the right place to ask for an esr31 branch on https://github.com/mozilla/gecko-dev yet?
08:31:05 err
08:31:15 is it possible to get an esr31 branch on https://github.com/mozilla/gecko-dev yet?

will need to patch here: http://hg.mozilla.org/build/mozharness/file/c7c9a537ecff/configs/vcs_sync/beagle.py#l485

hwine: is there any reason not to go ahead with this?

I see we can mirror from here:
https://hg.mozilla.org/releases/mozilla-esr31/
(Assignee)

Comment 1

4 years ago
Created attachment 8463850 [details] [diff] [review]
bug1045488_mozharness_v1.patch

Same config as for esr24, just with name changed to esr31.

Not done any staging testing.

Also see bug 1035384 (beagle refactoring) - would be interested in your feedback.
Assignee: nobody → pmoore
Status: NEW → ASSIGNED
Attachment #8463850 - Flags: review?(hwine)
(Assignee)

Comment 2

4 years ago
Hal is a little busy, but says if it is urgent he can take a look today. Does anyone know if this is urgent or not? I have no idea on the urgency.

Thanks,
Pete
Comment on attachment 8463850 [details] [diff] [review]
bug1045488_mozharness_v1.patch

Review of attachment 8463850 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm - afaik, one "extra" item, but consistency is probably more important at this point.

::: configs/vcs_sync/beagle.py
@@ +507,5 @@
> +            ],
> +        },
> +        "tag_config": {
> +            "tag_regexes": [
> +                "^B2G_",

I don't believe this clause is needed. We never place B2G_ tags on ESR repos.

However, I know that matches prior esr setups, and won't do anything "wrong", so not a blocker.
Attachment #8463850 - Flags: review?(hwine) → review+
(Assignee)

Comment 4

4 years ago
Thanks Hal!

Have left it with the regex, for consistency, and maybe in the cleanup bug we can take a look whether we want to change this for all the esr branches.

Landed:
  * default:     https://hg.mozilla.org/build/mozharness/rev/2cd4e4de46a2
  * production:  https://hg.mozilla.org/build/mozharness/rev/0c2710a85246

Please note, the new branch will only appear on github after the next commit lands in gecko-dev, unless I log onto the box and force push - which I prefer not to do in production unless necessary (as any manual work introduces risk). I'll keep my eye open for it today though - this page should return content when the branch has been created:

  * https://github.com/mozilla/gecko-dev/tree/esr31

At time of writing this still returns an HTTP 404 page but I anticipate this appearing sometime later today.
(Assignee)

Comment 5

4 years ago
Bingo! Seconds later it appeared. :D
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.