We may want to have a responsive design view of tablet/tv size UI when GAIA_DEVICE_TYPE is tablet or tv. Currently, the window size is hardcoded at . This issue is for adding the support of default window size based on current device build. I found the responsive design module already reads the pref value to customize its default size. We may leverage this feature to enable it.  https://github.com/mozilla-b2g/gaia/blob/master/tools/extensions/browser-helper%40gaiamobile.org/bootstrap.js#L120-L135
Created attachment 8463895 [details] [review] patch for this bug Hi Yuren and Alex, This is the patch to use customWidth and customHeight prefs to configure the responsive design UI. Please give me some feedbacks. Thanks.
Comment on attachment 8463895 [details] [review] patch for this bug Looks good and I agree with this idea, this can give us more flexibility to customize preferences for different device type.
Comment on attachment 8463895 [details] [review] patch for this bug offline discuss with john, we should fix bug 1039219 first.
Comment on attachment 8463895 [details] [review] patch for this bug Looks good, I'll let Yuren review this patch. My only concern in using these prefs is that, if we tweak the responsive design layout and modify the padding/border sizes, we would have to manually modify all these prefs. But that's something I can live with.
Thanks for this feedback. Yuren had blocked this bug with bug 1039219. We had discussed similar thing offline. After bug 1039219 landed, I will move the tweak to preferences.js. And others don't need to apply the tweak when they want to modify the prefs.
Created attachment 8471332 [details] [review] pr for this bug This is the patch for this issue and changes: 1. add custom-prefs to device type folders 2. load pref files to memory 3. customize the pref value while loading 4. separate prefs and user_prefs 5. modify the tests and create one for pref value customization. Please review it. Thanks.
Comment on attachment 8471332 [details] [review] pr for this bug code looks good but after offline discussion, John wants to wrap script loader for node.js, so cancel review request and please set me review again when you get updated pull request.
Comment on attachment 8471332 [details] [review] pr for this bug Hi Yuren, I had finished the script loader in utils-node.js. The related codes are also updated. But I don't know how to test it in node.js. So, please tell how to do it and review the code. Thanks.
Comment on attachment 8471332 [details] [review] pr for this bug looks good, thank you!
merged to master: https://github.com/mozilla-b2g/gaia/commit/b204365db8a6aea4d52c40dc572a7e3e9700172e
Reverted for B2G desktop build failures on windows: https://tbpl.mozilla.org/php/getParsedLog.php?id=45922620&tree=B2g-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=45920651&tree=B2g-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=45923725&tree=B2g-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=45924444&tree=B2g-Inbound https://github.com/mozilla-b2g/gaia/commit/2eeed1537be7719412506c083ad02da988037231
Created attachment 8473561 [details] [review] pr with windows supported Waiting for Gaia-Try and Gecko-Try before setting review.
Gecko try passed: https://tbpl.mozilla.org/?tree=Try&rev=938ad9b0608d
Comment on attachment 8473561 [details] [review] pr with windows supported Yuren, Please review this patch. I had included the windows parts and tested in Window box. The both gecko and gaia try had passed. Thanks.
merged to master: https://github.com/mozilla-b2g/gaia/commit/ae1fee6112b4206b3a8be8644321207991948308