1045545 - Remove dependency on amo-validator

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Mathieu Pillard [:mat]]

Surprise, zamboni still depends on amo-validator!

The only place where it's used is in mkt/files/helpers.py, where we import blacklisted_extensions and blacklisted_magic_numbers for the... File Viewer. 

We should figure out if we still need all that, remove all code that we can and the dependency on amo-validator.

Comment 1

[Andrew Williamson [:eviljeff]]

what are blacklisted_magic_numbers?

Comment 2

[Mathieu Pillard [:mat]]

We still use the File Viewer code (that's what the reviewer tools use).

`blacklisted_extensions` and `blacklisted_magic_numbers` are used to prevent viewing some specific files:

blacklisted_extensions = ("dll", "exe", "dylib", "so",
                          "sh", "class", "swf")
 
blacklisted_magic_numbers = (
        (0x4d, 0x5a),  # EXE/DLL
        (0x5a, 0x4d),  # Alternative for EXE/DLL
        (0x7f, 0x45, 0x4c, 0x46),  # UNIX elf
        (0x23, 0x21),  # Shebang (shell script)
        (0xca, 0xfe, 0xba, 0xbe),  # Java + Mach-O (dylib)
        (0xca, 0xfe, 0xd0, 0x0d),  # Java (packed)
        (0xfe, 0xed, 0xfa, 0xce),  # Mach-O
        (0x46, 0x57, 0x53),  # Uncompressed SWF
        (0x43, 0x57, 0x53),  # ZLIB compressed SWF
)

The easy solution would be to just copy those in zamboni.

Comment 3

[Andrew Williamson [:eviljeff]]

the same functions exist in app-validator too, if changing the import to there is easier.

Comment 4

[Mathieu Pillard [:mat]]

Good catch, that'll be even better.

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/67c095bc12e56d9d34aa3e555e341b617cf93947