1045584 - Remove everything relating to frames from OldDebugAPI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: v1

I moved most of the code from OldDebugAPI that was still used by EvalInFrame to that function. I also removed the XPConnect function debugDumpEvalInJSStackFrame, if we still need that I could instead put the guts of EvalInFrame somewhere else so the implementation can be shared.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8463964 [details] [diff] [review]
v1

Review of attachment 8463964 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Thanks for doing this!

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8463964 [details] [diff] [review]
v1

Review of attachment 8463964 [details] [diff] [review]:
-----------------------------------------------------------------

Hm, I never knew about DumpJSEval. It seems like it might have been pretty useful for debugging actually, but this code is pretty nasty. I think we could build a saner replacement if the need arises.

Comment 3

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db9349e9fe14

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db9349e9fe14