Closed Bug 1045590 Opened 6 years ago Closed 6 years ago

[Messages] make offAll remove all listeners in EventDispatcher

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Whiteboard: [sms-sprint-2.1S1])

Attachments

(1 file)

No description provided.
Attached file github PR
I changed the fact that "offAll" can remove all listeners in one go. This is especially useful for unit tests, but I know we do this in Compose too (this.clearListeners()) in `init` (probably for unit tests too, though :) ).
Assignee: nobody → felash
Attachment #8463979 - Flags: review?(azasypkin)
Blocks: 1045058
Comment on attachment 8463979 [details]
github PR

(In reply to Julien Wajsberg [:julienw] from comment #1)
> Created attachment 8463979 [details]
> github PR
> 
> I changed the fact that "offAll" can remove all listeners in one go. This is
> especially useful for unit tests, but I know we do this in Compose too
> (this.clearListeners()) in `init` (probably for unit tests too, though :) ).

Yeah, makes sense, r=me. I've just left tiny suggestion on test case naming.
Attachment #8463979 - Flags: review?(azasypkin) → review+
fixed nits and landed:
master: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [sms-sprint-2.1S1]
You need to log in before you can comment on or make changes to this bug.