1045600 - The "main bug number" should be shown in the row header

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P4)

Description

[:Paolo Amadini]

Each row should display the "main bug number" alongside the revision. This is obtained by looking at the commit message of the revision, and if not present it is taken from the first ancestor that has one.

Note that the revision from which the bug number is taken might not be part of the push. This is common when respinning a tryserver build using a new "try syntax", since the only pushed changeset is an empty patch with the try syntax in the commit message, based on the revision to try. However, solving this even only for bug numbers in the pushlog would be a great improvement.

This is particularly useful to developers monitoring the list of their own tryserver pushes.

Comment 1

[Ed Morley [:emorley]]

By row, do you mean the row for each commit, or for each push?

Comment 2

[:Paolo Amadini]

(In reply to Ed Morley [:edmorley] from comment #1)
> By row, do you mean the row for each commit, or for each push?

The row for each push, in other words the bug number should be visible when the row is collapsed.

Comment 3

[Ed Morley [:emorley]]

For pushes where there are multiple commits, and each commit is for a different bug, what should be displayed? ie: merges, checkin-neededs and even developer's own pushes (both try and non-try) where they are pushing a bunch of unrelated recent work?

Or is this feature primarily for try (eg porting bug 1020919 to treeherder)?

Comment 4

[:Paolo Amadini]

(In reply to Ed Morley [:edmorley] from comment #3)
> For pushes where there are multiple commits, and each commit is for a
> different bug, what should be displayed? ie: merges, checkin-neededs and
> even developer's own pushes (both try and non-try) where they are pushing a
> bunch of unrelated recent work?

Hm, for pushes with multiple commits in them, the most recent bug number might be followed by a comma and an ellipsis to make it clear that there are more.

> Or is this feature primarily for try (eg porting bug 1020919 to treeherder)?

That bug is probably referring to the same use case, yes. I have tryserver and integration branches in mind, where generally the pushes made by developers group together related bugs, thus one of them (the most recent in the bug queue) is enough to distinguish the push.

Comment 5

[Ed Morley [:emorley]]

If I understand correctly, one of the problems comment 0 was wanting to solve, was being able to see a bug number for commits that don't appear as part of the push. That's not something we can easily do, and will really need to be fixed by either autoland (when it pushes to try) or else the headless try proposal (bug 1055298) which will mean the actual commits will always be shown.

Without being able to do that, we're just left with showing bug numbers for commits that are already visible. Given that bug 1045602 will add sensible push summaries to the page title (based on these commits), and that we've tweaked the UI to be clearer since this bug was filed - I don't think there's a major win from adding one bug number to the push summary (particularly since there's often more than one bug number, especially on non-try).

If you can think of some other way we can improve your workflow, we'll be happy to try and help - but for this bug as filed, I don't think it's something that we can easily do.

Comment 6

[:Paolo Amadini]

I filed this bug when the rows for each push were collapsible, and collapsing them wasn't useful without a reference bug number. Now I think they aren't collapsible anymore, so I agree this change is not necessary.

Comment 7

[Ed Morley [:emorley]]

Ah I didn't realise this was more about that (now removed) view. Makes more sense now :-)