1045619 - [style editor] csscoverage report: pie chart of css usage: labels 'Used', 'Unused' and 'Use Preload' not localizable

Status: NEW

(DevTools :: Style Editor, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 34.0a1 20140728

The csscoverage report contains a pie chart for the css usage, but its labels  'Used', 'Unused' and 'Use Preload' are not localizable.

Comment 1

[Tim Nguyen :ntim]

Attachment: csscoverage-strings.patch

Works on top of bug 1016288

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8603718 [details] [diff] [review]
csscoverage-strings.patch

Review of attachment 8603718 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleeditor/StyleEditorUI.jsm
@@ +988,2 @@
>        data: [
> +        { size: data.summary.preload, label: L10N.getStr("cssCoverage.chart.preload") },

Nit: keep these lines under 80 characters by wrapping onto a new line if necessary

::: browser/locales/en-US/chrome/browser/devtools/styleeditor.properties
@@ +89,5 @@
>  confirmNavigationAway.buttonLeaveAccesskey=L
>  confirmNavigationAway.buttonStay=Stay on Page
>  confirmNavigationAway.buttonStayAccesskey=S
> +
> +# LOCALIZATION NOTE (cssCoverage) : Strings shown in CSS Coverage chart in

replace 'chart' with 'pie chart'

@@ +92,5 @@
> +
> +# LOCALIZATION NOTE (cssCoverage) : Strings shown in CSS Coverage chart in
> +# the style editor.
> +cssCoverage.chart.title = CSS Usage
> +cssCoverage.chart.preload = Used Preload

I have a feeling this string will be difficult to localize and could use a comment.  Maybe something like 'Shown for CSS that was used before the load event fired'

Comment 3

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).