Disable HTTP Proxy over HTTPS on Gecko 32

RESOLVED FIXED in Firefox 32

Status

()

Core
Networking: HTTP
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

32 Branch
mozilla32
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox31 unaffected, firefox32+ fixed, firefox33 unaffected, firefox34 unaffected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8464020 [details] [diff] [review]
BO

from bug 378637 comments 54 and 55


Approval Request Comment
[Feature/regressing bug #]: this one
[User impact if declined]: new feature that has reliability bugs related only to use of the feature (i.e. it is not generally destabilizing)
[Describe test coverage new/current, TBPL]: backout
[Risks and why]: minimal
[String/UUID change made/needed]: none

I'm going to ask that we disable this on FF32 via flipping an existing pref and instead target FF33. There is no UI - this is just new syntax in the PAC file format that won't be supported yet.

FF32 and FF33 are missing the related fixes for 1040930, 1040323, and 1043402. The first is on FF34 (and will be uplifted to 33) the latter two haven't landed at all yet. They're all expected to be small and suitable for FF33 but FF32 is too aggressive at this stage.

If it goes worse than planned we have plenty of time to disable on FF33, but this feature is eagerly awaited to give parity with Google's Compressing Data Proxy and it is receiving positive feedback.

-- comment 55 lmandel ---

OK. We'll back this out as per your suggestion. Can you please file a separate bug for the backout as that is much easier to track.
Attachment #8464020 - Flags: review+
Attachment #8464020 - Flags: approval-mozilla-beta?
status-firefox31: --- → unaffected
status-firefox32: --- → affected
status-firefox33: --- → unaffected
status-firefox34: --- → unaffected
tracking-firefox32: --- → +
Comment on attachment 8464020 [details] [diff] [review]
BO

beta+
Attachment #8464020 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/97a654ff8682
status-firefox32: affected → fixed
Target Milestone: --- → mozilla32

Comment 3

3 years ago
This caused test failures across many suites:
https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=97a654ff8682

Would you mind backing it out? (My beta clone is broken)
(In reply to Ed Morley [:edmorley] from comment #3)
> This caused test failures across many suites:
> https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=97a654ff8682
> 
> Would you mind backing it out? (My beta clone is broken)

of course. Then I need to figure out why my smoke test was fine.
Allow me. Backed out for mass bustage.
https://hg.mozilla.org/releases/mozilla-beta/rev/433a7a6a2c25

https://tbpl.mozilla.org/php/getParsedLog.php?id=44865109&tree=Mozilla-Beta
Assignee: nobody → mcmanus
status-firefox32: fixed → affected
Created attachment 8469717 [details] [diff] [review]
disable tls proxying bug 378637 on gecko 32
Attachment #8464020 - Attachment is obsolete: true
Comment on attachment 8469717 [details] [diff] [review]
disable tls proxying bug 378637 on gecko 32


this patch is a one line change to the previous pref backout - the pref switch was broken which is why this failed last time. The patch is r+'d in 1050598. This is very very safe.

I also wrote a test for it - unfortunately it exposed 2 other latent bugs in reconfiguration of PAC that are totally unrelated to the feature being disabled here. So I am omitting the test here, but will be commiting it to m-c along with the fixes to make it work. That's also bug 1050598
Attachment #8469717 - Flags: review+
Attachment #8469717 - Flags: approval-mozilla-beta?
Comment on attachment 8469717 [details] [diff] [review]
disable tls proxying bug 378637 on gecko 32

OK. Let's give this another go. beta+
Attachment #8469717 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/c9dec07b4148
status-firefox32: affected → fixed

Comment 10

3 years ago
You should also change the 32 beta note: 
https://www.mozilla.org/en-US/firefox/32.0beta/releasenotes/
xunxun, done in the initial bug. I left it for 32 beta because it was enabled for some part of the beta cycle.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
See Also: → bug 1125737
You need to log in before you can comment on or make changes to this bug.