1045647 - -webide option doesn't always work.

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Paul Rouget [:paul]]

I start Firefox like that:

> firefox -P dev -webide  -no-remote  -jsconsole

WebIDE doesn't open:

> Warning: unrecognized command line flag -webide

But, it works when I build WebIDE myself.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I think you need to add the command line handler and its manifest to the package-manifest.in.  See the other DevTools handler[1].

[1]: http://hg.mozilla.org/mozilla-central/annotate/ef1a3ed657fc/browser/installer/package-manifest.in#l363

Comment 2

[Paul Rouget [:paul]]

Attachment: v1

Ryan, can you confirm it works on Mac?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8479617 [details] [diff] [review]
v1

Review of attachment 8479617 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, packaged Firefox works with -webide on Mac with this.  It's impossible to quit the program when started with -webide via either Cmd-Q or the menu item, but that's for a different bug... ;)

Comment 4

[Paul Rouget [:paul]]

(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> Comment on attachment 8479617 [details] [diff] [review]
> v1
> 
> Review of attachment 8479617 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yes, packaged Firefox works with -webide on Mac with this.  It's impossible
> to quit the program when started with -webide via either Cmd-Q or the menu
> item, but that's for a different bug... ;)

Do you know if there's an easy way to fix that?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #4)
> (In reply to J. Ryan Stinnett [:jryans] from comment #3)
> > Comment on attachment 8479617 [details] [diff] [review]
> > v1
> > 
> > Review of attachment 8479617 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Yes, packaged Firefox works with -webide on Mac with this.  It's impossible
> > to quit the program when started with -webide via either Cmd-Q or the menu
> > item, but that's for a different bug... ;)
> 
> Do you know if there's an easy way to fix that?

I don't know, I am not sure what the cause is.  Haven't had time to look at it in depth.  In any case, this patch it still correct and worth landing.

Comment 6

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=77a675983f59

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/ea44b45c8a32

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea44b45c8a32