Closed Bug 1045662 Opened 8 years ago Closed 8 years ago

symbolstore.py install manifest processing not working correctly on Windows

Categories

(Toolkit :: Crash Reporting, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

I just checked and apparently my fix didn't quite fix this on Windows. This is the firefox.exe symbol file from today's nightly:
http://symbols.mozilla.org/firefox/firefox.pdb/8DC22F5639B44DACAF458243D2CA781A2/firefox.sym

Note the lines like:
FILE 9 hg:hg.mozilla.org/mozilla-central:obj-firefox/dist/include/mozilla/TypedEnum.h:b17cad2d1e5e

I think this is a silly path normalization issue. If I read the dist/include install manifest locally on Windows and run the same code that symbolstore.py does to build the file mapping, I get paths like:
'd:\\build\\debug-mozilla-central\\dist\\include\\mozilla/Assertions.h'

So I probably just need to normalize the paths I get out of the InstallManifest.
Paths on Windows are hard. :-(
Attachment #8464062 - Flags: review?(gps)
Attachment #8464062 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/413586b58d1a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.