1045662 - symbolstore.py install manifest processing not working correctly on Windows

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

I just checked and apparently my fix didn't quite fix this on Windows. This is the firefox.exe symbol file from today's nightly:
http://symbols.mozilla.org/firefox/firefox.pdb/8DC22F5639B44DACAF458243D2CA781A2/firefox.sym

Note the lines like:
FILE 9 hg:hg.mozilla.org/mozilla-central:obj-firefox/dist/include/mozilla/TypedEnum.h:b17cad2d1e5e

I think this is a silly path normalization issue. If I read the dist/include install manifest locally on Windows and run the same code that symbolstore.py does to build the file mapping, I get paths like:
'd:\\build\\debug-mozilla-central\\dist\\include\\mozilla/Assertions.h'

So I probably just need to normalize the paths I get out of the InstallManifest.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: add an extra normcase to symbolstore.py path handling to fix Windows

Paths on Windows are hard. :-(

Comment 2

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/413586b58d1a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/413586b58d1a