1045668 - Bare Metal Provisioning 2008 Puppet: Windows MSI packages support

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Mark Cornmesser [:markco] OOO 2024/04/15]

Attachment: 1045668.patch

There is still some oddness with Binscope. The files are being installed but it is not showing as an application in the control panel. Which may not be a major issue.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8464762 [details] [diff] [review]
1045668.patch

Review of attachment 8464762 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks great, and certainly a lot more maintainable.

I don't know what to say about binscope - is that an MSIEXEC flag problem or something?

::: modules/packages/manifests/7z920.pp
@@ +2,4 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  class packages::7z920 {
> +    #Source http://www.7-zip.org/

:( less readable, and no leading space in the comment

Comment 3

[Mark Cornmesser [:markco] OOO 2024/04/15]

Attachment: 1045668.patch

Let's go ahead and land this if it looks good. I don't think the oddity with binscope will cause an issue because we do not access it through the UI.

Comment 4

[Mark Cornmesser [:markco] OOO 2024/04/15]

Attachment: 1045668.patch