Closed Bug 1045700 Opened 6 years ago Closed 6 years ago

Add ability to display changelogs in versioninfo.py

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

Attached patch print_changelogSplinter Review
Usage:
versioninfo.py changelog <module> [--from <version or rev> [--to <version or rev>]]

Displays a list of all commit descriptions between the --from and --to targets.
Attachment #8464072 - Flags: review?(wlachance)
Comment on attachment 8464072 [details] [diff] [review]
print_changelog

Review of attachment 8464072 [details] [diff] [review]:
-----------------------------------------------------------------

This is great. However, I don't think we should need to create a version subclass. Can't we just use python's existing version support:

http://stackoverflow.com/a/11887885/295132

r+ with that change or a convincing argument on why we need to roll our own. :)
Attachment #8464072 - Flags: review?(wlachance) → review+
Oh cool, I didn't know about that. Distutils is so full of undocumented surprises (also I think some python docstrings just called me anal).

I'll update and re-test the patch before pushing.
https://hg.mozilla.org/mozilla-central/rev/c5db7ca22928
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.