Closed
Bug 1045700
Opened 7 years ago
Closed 7 years ago
Add ability to display changelogs in versioninfo.py
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(1 file)
4.74 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
Usage: versioninfo.py changelog <module> [--from <version or rev> [--to <version or rev>]] Displays a list of all commit descriptions between the --from and --to targets.
Attachment #8464072 -
Flags: review?(wlachance)
Comment 1•7 years ago
|
||
Comment on attachment 8464072 [details] [diff] [review] print_changelog Review of attachment 8464072 [details] [diff] [review]: ----------------------------------------------------------------- This is great. However, I don't think we should need to create a version subclass. Can't we just use python's existing version support: http://stackoverflow.com/a/11887885/295132 r+ with that change or a convincing argument on why we need to roll our own. :)
Attachment #8464072 -
Flags: review?(wlachance) → review+
Assignee | ||
Comment 2•7 years ago
|
||
Oh cool, I didn't know about that. Distutils is so full of undocumented surprises (also I think some python docstrings just called me anal). I'll update and re-test the patch before pushing.
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5db7ca22928
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c5db7ca22928
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•