1045846 - Job details: Builds are missing the "go to build directory" link

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

In TBPL if you click on a build's job "B" to see its details pane you get offered a "go to build directory" link what points to to the actual binary.

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Workaround: view the logs, then click on the raw log link, which gets me eg http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-32f81452ea26/try-macosx64/try-macosx64-bm87-try1-build12102.txt.gz

...which I can then hand-edit to get the parent build dir.

Would really like to see this - treeherder seems much nicer generally aside from this. In devtools often we have patches in-progress for quite a while as tests are written or fixed up prior to landing, so having try builds is a great way to do early testing and validation.

Comment 2

[Ed Morley [:emorley]]

(Making not a blocker given there is a workaround)

Comment 3

[Jonathan French (:jfrench)]

An fyi for Jeff also, the raw log is available directly off the job details panel. So don't need to navigate to the structured log first in the above workaround. Just click and you're there.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Ed Morley [:edmorley] from comment #2)
> (Making not a blocker given there is a workaround)

I disagree. We ( devtools ) use try builds a lot, and this is the only real pain associated with treeherder. Getting to the build directory easily is key, and obviously a shallow fix.

Comment 5

[Ed Morley [:emorley]]

(In reply to Jeff Griffiths (:canuckistani) from comment #4)
> (In reply to Ed Morley [:edmorley] from comment #2)
> > (Making not a blocker given there is a workaround)
> 
> I disagree. We ( devtools ) use try builds a lot, and this is the only real
> pain associated with treeherder. Getting to the build directory easily is
> key, and obviously a shallow fix.

A "blocker" in this situation means bugs blocking bug 1030636, which is purely the bare minimum requirements for sheriffs (and devs who wish to) switching to treeherder in preference of TBPL (which is a Q3 goal that I've been told is non-negotiable). The deps of that bug being fixed doesn't mean TBPL is being switched off immediately, or that there won't still be treeherder issues remaining that irritate people (including the sheriffs). The next phase of work after that is being covered by bug 1059400 (which this bug now blocks) - which is for issues that can wait a week or two longer if it came to it.

That's not to say this won't get fixed imminently anyway (as you say, this won't take long to fix using the hacky TBPL-like implementation), but more that it doesn't directly block sheriffs from switching and thus the Q3 goal.

For the bug tables (to give an idea of the severity of bugs in each group) see: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Bugs_.26_Project_Tracking

Comment 6

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Ed Morley [:edmorley] from comment #5)
> (In reply to Jeff Griffiths (:canuckistani) from comment #4)
> > (In reply to Ed Morley [:edmorley] from comment #2)
> > > (Making not a blocker given there is a workaround)
> > 
> > I disagree. We ( devtools ) use try builds a lot, and this is the only real
> > pain associated with treeherder. Getting to the build directory easily is
> > key, and obviously a shallow fix.
> 
> A "blocker" in this situation means bugs blocking bug 1030636, which is
> purely the bare minimum requirements for sheriffs (and devs who wish to)
> switching to treeherder in preference of TBPL (which is a Q3 goal that I've
> been told is non-negotiable).

Ah, fair enough. Thanks for the info, and sorry for the distraction.

Comment 7

[David Burns :automatedtester]

Attachment: Add Go To Build Directory

Comment 8

[David Burns :automatedtester]

https://github.com/mozilla/treeherder-ui/commit/27074358fe414ab712b41b480fdabe01e252b92a

Comment 9

[Jim Jeffery not reading bug-mail 1/2/11]

How long does this take to show up in 'treeherder' views ?

Looking at latest builds on m-c treeherder I click on a 'B' (completed build) and I see the information about what slave was used, build time duration etc, but I'm not seeing any link to the build directory on the FTP like we do on TBPL...

Where should it appear ?>  maybe I'm not looking in right place...

Comment 10

[Jonathan French (:jfrench)]

The time varies depending on how frequently master is pushed to the dev, stage and production instances. Currently afaik there hasn't been a push for a few days due to some larger changes which have been landed on master, but need some additional tweaks before it all gets pushed.

Typically the first push is to dev/stage, when it occurs. Then less frequently to production.

Links to the 3 dashboard instances can be found here via the ReadMe
https://github.com/mozilla/treeherder-ui

It seems in some cases bugs get marked fixed in Bugzilla immediately when landed on master, but before they have been pushed and verified on dev. I guess it varies depending on bug owner.

Comment 12

[(mostly gone) XtC4UaLL [:xtc4uall]]

Seems this is now live/in production.
Thanks!

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/55091eb19cb27b2c9a24295b378a9192941d89a3
Bug 1045846: Part 1: Remove the typo in the model name

https://github.com/mozilla/treeherder/commit/66a5c45392ffe31284f6dc0c14ca4994e21160ff
Bug 1045846: Part 2: Add in 'Go to build directory'