1045857 - Filters: Filtering by buildername returns zero results

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

Compare TBPL
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=WINNT%205.2%20mozilla-inbound%20build

with TH:
https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&field-job_type_name=winnt%205.2%20mozilla-inbound%20build

I'd expect to see all checkins with given criterias having clickable "B" symbols so I'm able to get their details pane.

Comment 1

[Mauro Doglio [:mdoglio]]

A quick and easy way to fix this would be to do the filtering server side. We can use the reference data signatures table to obtain a signature_id and filter the job query on that.

Comment 2

[Jonathan Eads ( :jeads )]

After analyzing this problem further I decided it would be best to include the buildername as a property with every job returned in treeherder. While searching server side against buidernames would be lighter weight on the data returned it also limits the search box to the terms present in the buildername and not the ones actually displayed. A good example of this would be windows operating system names in the buildername. When "Windows 8" is displayed as the operating system in the UI, it corresponds to "WINNT 6.2" in the buildername. So if we only searched the buildername you would get no results for "Windows 8" which would be confusing especially for reporting systems that have no buildername equivalent.

The web service methods returning job data now include a property called ref_data_name. I'm avoiding the use of buildername/jobname to keep this generic for non-buildbot reporting systems.

https://treeherder.mozilla.org/api/project/mozilla-central/resultset/1/get_resultset_jobs/?format=json&result_set_ids=446

This property is available on all job objects in the javascript and will likely be used for a variety of things in addition to filtering. So, I've included the displayed platform, group, and job data found in the UI in addition to the ref_data_name property: 

https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/directives/clonejobs.js#L249

This way, search will work as expected when the reporting system has no buildername.

In addition to being available in the "Filter platform & jobs" search, it's also available in the global filters as "buildername/jobname". However, the global filters do not handle multiple word query values correctly. I anticipate removing the global filters entirely in favor of using some different variations of the quick search so I think this will be a non-issue shortly.

There are two pull requests that address these issues along with a few others:

https://github.com/mozilla/treeherder-service/pull/196/files
https://github.com/mozilla/treeherder-ui/pull/142/files

I also increased the "name" field in the https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/sql/template_schema/treeherder_reference_1.sql.tmpl#L65 to varchar(255). I'm seeing builder names for various emulators that are starting to exceed 100 characters and I think it would be prudent to provide greater capacity there before the current size limit is exceeded.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/82c1281c9cf3de16e9febc5f812a1ca09e24e464
Bug 1045857, Bug 1060448, Bug 1059322 - Added filtering by buildername/jobname to search box and url

https://github.com/mozilla/treeherder/commit/1ce62f558f30b57f4a7a292333e047e2c7a5c95a
Merge pull request #142 from mozilla/search-by-buildername

Bug 1045857, Bug 1060448, Bug 1059322 - Added filtering by buildername/j...