1045895 - replace GetParentStyleContextFrame in ElementRestyler::Restyle with an outparam got from RestyleSelf

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

See bug 931668 comment 145.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=db2b668ca558

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch v2

A patch that doesn't assert.

Comment 4

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=4b35442393bd

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8486979 [details] [diff] [review]
patch v2

>+  if (*aProviderFrame && *aProviderFrame != providerFrame) {
>+    LOG_RESTYLE_CONTINUE("we had different provider frame from the previous "
>+                         "same-style continuation");
>+    result = eRestyleResult_Continue;
>+  }


I don't understand why you're hitting this case, but r=dbaron, I guess.

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88d6381ad5d1

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88d6381ad5d1

Comment 8

[Cameron McCormack (:heycam)]

Backed out for causing bug 1070759.

https://hg.mozilla.org/integration/mozilla-inbound/rev/24b61af1917e

Comment 9

[Cameron McCormack (:heycam)]

ElementRestyler is gone.