1045921 - Clean up Clipboard.java

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

There are a few oddities hanging around here:


    private static android.content.ClipboardManager getClipboardManager(Context context) {
        // In API Level 11 and above, CLIPBOARD_SERVICE returns android.content.ClipboardManager,
        // which is a subclass of android.text.ClipboardManager.
        return (android.content.ClipboardManager) mContext.getSystemService(Context.CLIPBOARD_SERVICE);
    }

... why use mContext when there's a context argument?!

And mContext should probably be tidied up some.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Clean up Clipboard.java. v1

This patch does the following:

* Eliminate access to enclosing private members by making some package-scoped, and by inlining two methods...
* Inlines the two one-liner methods. They're nice for explanation, but not hugely valuable, and this avoids having two one-liner package-scoped methods!
* Other changes as commented.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8464358 [details] [diff] [review]
Clean up Clipboard.java. v1

Review of attachment 8464358 [details] [diff] [review]:
-----------------------------------------------------------------

I kinda like the helper methods, but I agree there are probably better ways to deal with them as well.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/71b099257951

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/71b099257951