Closed Bug 1045969 Opened 6 years ago Closed 6 years ago

export_dirs and libs_dir need to take into account comm-central

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: iann_bugzilla, Assigned: glandium)

References

Details

(Keywords: dogfood, regression)

Attachments

(3 files, 2 obsolete files)

Since the patch from bug 1043344 landed not all directories in comm-central are being traversed during export. It apparently has the same kind of root cause as bug 1045329
Possibly needed for libs_dir too
Summary: export_dirs needs to take into account comm-central → export_dirs and libs_dir need to take into account comm-central
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Attached file Generated root.mk
root.mk generated with this patch applied and patch from https://pastebin.mozilla.org/5703206
Failing with:
make[5]: *** No rule to make target `../../xpcom/glue/standalone/libxpcomglue.a.desc', needed by `seamonkey'.  Stop.
make[5]: Leaving directory `/home/gizmo/central/c-c/obj-sm/suite/app'
make[4]: *** [../suite/app/target] Error 2
Attached file Generated root-deps.mk
Generated from the same build attempt.
Attachment #8464438 - Attachment is obsolete: true
Attachment #8464438 - Flags: review?(gps)
Comment on attachment 8464456 [details] [diff] [review]
Use more paths relative to root topobjdir for backend files for similar reasons as in bug 1045329

Can you test this, Ian, this should address the "No rule to make target `../../xpcom/glue/standalone/libxpcomglue.a.desc', needed by `seamonkey'" thing.
Attachment #8464456 - Flags: feedback?(iann_bugzilla)
and paths relative to the "local" topobjdir for linkage.
Attachment #8464457 - Flags: review?(gps)
Attachment #8464456 - Attachment is obsolete: true
Attachment #8464456 - Flags: review?(gps)
Attachment #8464456 - Flags: feedback?(iann_bugzilla)
Comment on attachment 8464457 [details] [diff] [review]
Use paths relative to root topobjdir for backend files for similar reasons as in bug 1045329

Only change compared to previous attachment is the summary.
Attachment #8464457 - Flags: feedback?(iann_bugzilla)
Comment on attachment 8464457 [details] [diff] [review]
Use paths relative to root topobjdir for backend files for similar reasons as in bug 1045329

Redirecting to mshal, as gps is on pto.
Attachment #8464457 - Flags: review?(gps) → review?(mshal)
Comment on attachment 8464457 [details] [diff] [review]
Use paths relative to root topobjdir for backend files for similar reasons as in bug 1045329

Yes, this patch seems to fix the issue identified. Thanks.
Attachment #8464457 - Flags: feedback?(iann_bugzilla) → feedback+
Attachment #8464457 - Flags: review?(mshal) → review+
Blocks: 1043344
No longer depends on: 1043344
Keywords: dogfood
Keywords: regression
https://hg.mozilla.org/mozilla-central/rev/0d3520e9f0fb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
The current bustage at https://tbpl.mozilla.org/?tree=Thunderbird-Trunk is a different problem now?
(In reply to Frank Wein [:mcsmurf] from comment #14)
> The current bustage at https://tbpl.mozilla.org/?tree=Thunderbird-Trunk is a
> different problem now?

Yes
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.