Closed Bug 1046003 Opened 6 years ago Closed 6 years ago

seeking within an ogv partially gives black frames/flickering

Categories

(Core :: Audio/Video, defect)

31 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla34
Tracking Status
firefox31 --- wontfix
firefox32 + verified
firefox33 + verified
firefox34 + verified

People

(Reporter: xtc4uall, Assigned: cpearce)

References

()

Details

(Keywords: regression, testcase)

Attachments

(3 files)

STR:

* open given URL
* seek around in the last third

-> notice the flickering/black frames

Last good revision: 1417d180a1d8 (2014-04-01)
First bad revision: 4941a2ac0786 (2014-04-02)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1417d180a1d8&tochange=4941a2ac0786

Last good revision: b22e89d7944f
First bad revision: 9c0afbe41ce8
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b22e89d7944f&tochange=9c0afbe41ce8

=> regressed by Bug 778077
Chris, does it ring a bell?
Flags: needinfo?(cpearce)
Attached file Testcase
This testcase should show load a video, seek, and render a frame. The frame doesn't render in Firefox 31.
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Flags: needinfo?(cpearce)
The problem is that we're hitting a run of duplicate frames in the file, and the seek is terminating on a duplicate. Duplicates don't have an image, so we can't paint it.

Fix is simple; when we encounter a duplicate in MediaDecoderStateMachine::DropVideoUpToSeekTarget, we copy forward the Image from the previous frame, and stash that frame if we drop, so that we can repeat the process if the next frame is also a duplicate.
Attachment #8468761 - Flags: review?(kinetik)
We should uplift this to beta. I don't think it's worth chemspilling for this.
Attachment #8468761 - Flags: review?(kinetik) → review+
(In reply to Chris Pearce (:cpearce) from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd3a6bdf339

Confirmed fixed URL + attachment 8468755 [details] against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140806210117 CSet: 1854d22e1d06

Thanks!
https://hg.mozilla.org/mozilla-central/rev/3dd3a6bdf339
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Verified in comment 6
Status: RESOLVED → VERIFIED
Chris, when you have a second, please fill the uplift request! Thanks
Comment on attachment 8468761 [details] [diff] [review]
Patch: Ensure we don't get a duplicate frame after seek

Approval Request Comment
[Feature/regressing bug #]: fastSeek, bug 778077
[User impact if declined]: Seeking an Ogg Theora video can result in a blank frame being painted, and the video being temporarily 0 sized.
[Describe test coverage new/current, TBPL]: We already have extensive seeking mochitests.
[Risks and why]:  Seems low risk; we have test coverage.
[String/UUID change made/needed]: None.
Attachment #8468761 - Flags: approval-mozilla-beta?
Attachment #8468761 - Flags: approval-mozilla-aurora?
Flags: needinfo?(cpearce)
Attachment #8468761 - Flags: approval-mozilla-beta?
Attachment #8468761 - Flags: approval-mozilla-beta+
Attachment #8468761 - Flags: approval-mozilla-aurora?
Attachment #8468761 - Flags: approval-mozilla-aurora+
Attached patch Beta PatchSplinter Review
Rebased on beta.
Attachment #8469605 - Flags: feedback?(ryanvm)
Flags: needinfo?(cpearce)
Comment on attachment 8469605 [details] [diff] [review]
Beta Patch

LGTM, thanks :)
Attachment #8469605 - Flags: feedback?(ryanvm) → feedback+
Reproduced in Firefox 31 RC under Win 7 64-bit.

Verified as fixed using Firefox 32 beta 6 (20140811180644) and latest Aurora 33.0a2 (20140811004001).
Keywords: verifyme
QA Contact: petruta.rasa
You need to log in before you can comment on or make changes to this bug.