1046003 - seeking within an ogv partially gives black frames/flickering

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

STR:

* open given URL
* seek around in the last third

-> notice the flickering/black frames

Last good revision: 1417d180a1d8 (2014-04-01)
First bad revision: 4941a2ac0786 (2014-04-02)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1417d180a1d8&tochange=4941a2ac0786

Last good revision: b22e89d7944f
First bad revision: 9c0afbe41ce8
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b22e89d7944f&tochange=9c0afbe41ce8

=> regressed by Bug 778077

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Chris, does it ring a bell?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Testcase

This testcase should show load a video, seek, and render a frame. The frame doesn't render in Firefox 31.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Ensure we don't get a duplicate frame after seek

The problem is that we're hitting a run of duplicate frames in the file, and the seek is terminating on a duplicate. Duplicates don't have an image, so we can't paint it.

Fix is simple; when we encounter a duplicate in MediaDecoderStateMachine::DropVideoUpToSeekTarget, we copy forward the Image from the previous frame, and stash that frame if we drop, so that we can repeat the process if the next frame is also a duplicate.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should uplift this to beta. I don't think it's worth chemspilling for this.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd3a6bdf339

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to Chris Pearce (:cpearce) from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd3a6bdf339

Confirmed fixed URL + attachment 8468755 [details] against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140806210117 CSet: 1854d22e1d06

Thanks!

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3dd3a6bdf339

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified in comment 6

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Chris, when you have a second, please fill the uplift request! Thanks

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8468761 [details] [diff] [review]
Patch: Ensure we don't get a duplicate frame after seek

Approval Request Comment
[Feature/regressing bug #]: fastSeek, bug 778077
[User impact if declined]: Seeking an Ogg Theora video can result in a blank frame being painted, and the video being temporarily 0 sized.
[Describe test coverage new/current, TBPL]: We already have extensive seeking mochitests.
[Risks and why]:  Seems low risk; we have test coverage.
[String/UUID change made/needed]: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/67b46a59bcc0

Needs rebasing for the beta uplift.

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta Patch

Rebased on beta.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8469605 [details] [diff] [review]
Beta Patch

LGTM, thanks :)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/91f078c385f8

Comment 15

[Petruta Horea [:phorea]]

Reproduced in Firefox 31 RC under Win 7 64-bit.

Verified as fixed using Firefox 32 beta 6 (20140811180644) and latest Aurora 33.0a2 (20140811004001).