Closed Bug 1046025 Opened 10 years ago Closed 10 years ago

Add component alpha support to TiledThebesLayer

Categories

(Core :: Graphics: Layers, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

      No description provided.
Attachment #8464544 - Flags: review?(nical.bugzilla)
Comment on attachment 8464544 [details] [diff] [review]
Add component alpha support

Review of attachment 8464544 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +654,5 @@
> +                          gfxContentType aContent,
> +                          SurfaceMode aMode,
> +                          bool *aCreatedTextureClient,
> +                          bool aCanRerasterizeValidRegion,
> +                          RefPtr<TextureClient>* aBackBufferOnWhite)

nit: at this point I'd make both TextureClients out parameters instead of one return value and one out parameter, but that's mostly a matter of taste.
Attachment #8464544 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/47101da7d564
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: