1046039 - Have a longer time window for users to view Terms of Service and Privacy Notice from the Loop panel

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly and Aurora 20140728 on Windows 8.1

Clicking on the Loop toolbar button for the first time, the user can seen the links to the Terms of Service and the Privacy Notice, but clicking the first one will open it and cause the panel to close. Reopening it doesn't show the links again.

Should these links be shown for longer, e.g. until Loop is used for the first time to make a call?

Comment 1

[Mark Banner (:standard8)]

RT or Darrin probably need to make the call here.

Comment 2

[Romain Testard [:RT]]

(In reply to Archaeopteryx [:aryx] from comment #0)
> Firefox Nightly and Aurora 20140728 on Windows 8.1
> 
> Clicking on the Loop toolbar button for the first time, the user can seen
> the links to the Terms of Service and the Privacy Notice, but clicking the
> first one will open it and cause the panel to close. Reopening it doesn't
> show the links again.
> 
> Should these links be shown for longer, e.g. until Loop is used for the
> first time to make a call?

That sounds like the best way forward - stop showing the ToS and privacy policy links when you ever have received an incoming call (even if you never replied or declined the call)

I needinfo Geoff for info here as he was part of the decision to implement it the way it was implemented. I suspect it won't be an issue from your standpoint Geoff given it means users get exposed to the links for a longer period of time (until they receive a call VS previous decision to only expose the links the first time the panel was brought down) ?

Comment 3

[Geoff Piper]

I feel like we have been down this road before, but to summarize for early release channels for non-Firefox account holders, for both the initiator of a call and the receiver of a call, no matter how the call is started or received, for the first time both the initiator and receiver uses this service but not thereafter because they would have seen it the first time, we are to display in the UX window (as Darrin has done already and is implemented but without the links working to date), the Legal copy "By using this product, you agree to the Terms of Use [LINK] and Privacy Notice [LINK]."

Am I missing something? What is new here and why is there an issue?

The real question here relates back to the other bugs (specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1044411) of getting the TOS URL identified, linked and live to the users.

Comment 4

[Romain Testard [:RT]]

(In reply to Geoff Piper from comment #3)
> I feel like we have been down this road before, but to summarize for early
> release channels for non-Firefox account holders, for both the initiator of
> a call and the receiver of a call, no matter how the call is started or
> received, for the first time both the initiator and receiver uses this
> service but not thereafter because they would have seen it the first time,
> we are to display in the UX window (as Darrin has done already and is
> implemented but without the links working to date), the Legal copy "By using
> this product, you agree to the Terms of Use [LINK] and Privacy Notice
> [LINK]."
> 
> Am I missing something? What is new here and why is there an issue?
> 
> The real question here relates back to the other bugs (specifically
> https://bugzilla.mozilla.org/show_bug.cgi?id=1044411) of getting the TOS URL
> identified, linked and live to the users.

The issue is:
1 We display both links on FTU fine
2 On FTU if you click one of the links you get there fine although the panel closes as you get to the link destination
3 Therefore as a user you never have a chance to click the second link as you now can't see the links anymore

The solution proposed is to stop displaying the links after you receive your first incoming call (so you get a chance to click both links until you receive your first call) rather than stop displaying links after you opened and closed the panel.

Is that fine with you?

Comment 5

[Geoff Piper]

I believe this is fine. Is there a way I can see this live as a demo though (without having to set up a new Nightly profile etc.)? This was not my experience when I did my FTU experience.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The second link (privacy notice) is broken at the moment (bug 1034841). You can let Firefox the legal text again by opening about:config from the location bar and resetting the loop.seenToS preference.

Comment 7

[Mark Banner (:standard8)]

(In reply to Archaeopteryx [:aryx] from comment #6)
> The second link (privacy notice) is broken at the moment (bug 1034841). You
> can let Firefox the legal text again by opening about:config from the
> location bar and resetting the loop.seenToS preference.

Geoff, you can try the current nightly with this, or do you want a version to try after the suggested change of comment 4?

Comment 8

[Geoff Piper]

I installed a new Nightly profile, and went through the initiation of a call for Hello! again...however, the Terms of Use do not link correctly to a dedicated URL for the Hello! specific terms of service (instead they link to here: https://accounts.firefox.com/legal/terms...which is for FxAccounts generally). 

I believe we need the dedicated URL to host the Hello! specific Nightly terms of use (which are located for now still in the same GitHub repo cited above).

The Privacy Notice link is correct now.

Comment 9

[Maire Reavy [:mreavy]]

This looks to be a dup of Bug 1035846.  Please reopen if there is something different about this bug.

Comment 10

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #9)
> This looks to be a dup of Bug 1035846.  Please reopen if there is something
> different about this bug.

Yes, the discussion was around how long to display the links for. I've extracted it out into the user story and updated the description to reflect it better.

Comment 11

[Maire Reavy [:mreavy]]

RT -- Is this something that can be moved to Fx35 or do we need it for the first release (Fx34)?  Can you talk with Geoff and then advise?

Comment 12

[Romain Testard [:RT]]

After a discussion with Geoff he confirmed this is a requirement from his standpoint, we can't release without this implemented.

Comment 13

[Geoff Piper]

(In reply to Romain Testard [:RT] from comment #12)
> After a discussion with Geoff he confirmed this is a requirement from his
> standpoint, we can't release without this implemented.

Correct

Comment 14

[Mark Banner (:standard8)]

Attachment: Have a longer time window for users to view Terms of Service and Privacy Notice from the Loop panel.

Simple patch to move the pref setting as described in the user story. This makes the ToS & Privacy notice stay up until the first incoming call is received.

Comment 15

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/851898432b6f

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/851898432b6f

Comment 17

[u279076]

Does this need manual testing or is testsuite coverage sufficient?

Comment 18

[u279076]

Mark, can you please answer comment 17?

Comment 19

[Mark Banner (:standard8)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #17)
> Does this need manual testing or is testsuite coverage sufficient?

Probably manual testing for now. This should verify that the ToS and privacy link are displayed on a fresh profile until a call is received.

Comment 20

[u279076]

Sorry, this fell off my radar. I have now verified this is working as described in comment 19 using today's Aurora build.