[VsD Refresh] Lockscreen Visual Refresh > Missing HiDPI notifications arrow assets

RESOLVED FIXED in 2.1 S1 (1aug)

Status

Firefox OS
Gaia::System::Lockscreen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mnjul, Assigned: mnjul)

Tracking

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

In bug 1023500, HiDPI image files for the "more notification" arrow were not committed to the repository (we currently have /system/style/lockscreen/images/lockscreen_notification_arrow.png only without the @1.5x/2x/2.25x versions). This bug will bring them to the repository.
Created attachment 8464621 [details] [review]
Patch (PR @ GitHub)

Hi Amy, the image files have been restored. Please see if the "more notifications" arrow in lockscreen is good now, thanks!
Attachment #8464621 - Flags: ui-review?(amlee)
Comment on attachment 8464621 [details] [review]
Patch (PR @ GitHub)

And Greg, please review this trivial patch for me. Thanks.
Attachment #8464621 - Flags: review?(gweng)

Comment 3

3 years ago
Comment on attachment 8464621 [details] [review]
Patch (PR @ GitHub)

Hi John, 

The arrow looks good now. Thanks
Attachment #8464621 - Flags: ui-review?(amlee) → ui-review+
Comment on attachment 8464621 [details] [review]
Patch (PR @ GitHub)

Let's land this.
Attachment #8464621 - Flags: review?(gweng) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/3407b3ea142b2b175ea6bc46e0fbce4f8c7850b2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.