Closed Bug 1046109 Opened 7 years ago Closed 7 years ago

[I/O] Cleanup and generalize |UnixSocketConsumer|

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(11 files, 1 obsolete file)

16.19 KB, patch
qdot
: review+
Details | Diff | Splinter Review
4.80 KB, patch
qdot
: review+
Details | Diff | Splinter Review
5.67 KB, patch
qdot
: review+
Details | Diff | Splinter Review
3.47 KB, patch
qdot
: review+
Details | Diff | Splinter Review
3.26 KB, patch
qdot
: review+
Details | Diff | Splinter Review
2.46 KB, patch
qdot
: review+
Details | Diff | Splinter Review
4.94 KB, patch
qdot
: review+
Details | Diff | Splinter Review
4.07 KB, patch
qdot
: review+
Details | Diff | Splinter Review
3.47 KB, patch
qdot
: review+
Details | Diff | Splinter Review
23.06 KB, patch
qdot
: review+
Details | Diff | Splinter Review
11.85 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
|BluetoothSocket| is a fork of |UnixSocketConsumer| with modifications for Bluedroid. Both classes should be based on the same code as far as possible.

A first step is the cleanup and generalization of the implementation of |UnixSocketConsumer|, so that |BluetoothSocket| can be build on top of it.
Attachment #8464689 - Flags: review?(kyle)
Attachment #8464693 - Flags: review?(kyle)
These patches are only about refactoring and cleaning up. The related Bluetooth patches are attached to bug 992206.
Attachment #8464683 - Flags: review?(kyle) → review+
Attachment #8464684 - Flags: review?(kyle) → review+
Attachment #8464685 - Flags: review?(kyle) → review+
Attachment #8464686 - Flags: review?(kyle) → review+
Attachment #8464687 - Flags: review?(kyle) → review+
Attachment #8464688 - Flags: review?(kyle) → review+
Attachment #8464689 - Flags: review?(kyle) → review+
Attachment #8464691 - Flags: review?(kyle) → review+
Attachment #8464692 - Flags: review?(kyle) → review+
Attachment #8464693 - Flags: review?(kyle) → review+
Attachment #8464694 - Flags: review?(kyle) → review+
Everything looks good, hopefully that'll make debugging easier too. Wondering if we might be able to set up gtest for this module soon.
Changes since v1:

  - added missing include statements
Attachment #8464689 - Attachment is obsolete: true
Attachment #8465356 - Flags: review+
You need to log in before you can comment on or make changes to this bug.