1046109 - [I/O] Cleanup and generalize |UnixSocketConsumer|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

|BluetoothSocket| is a fork of |UnixSocketConsumer| with modifications for Bluedroid. Both classes should be based on the same code as far as possible.

A first step is the cleanup and generalization of the implementation of |UnixSocketConsumer|, so that |BluetoothSocket| can be build on top of it.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1046109: Add |SocketConsumerBase| and inherit |UnixSocketConsumer| from it

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1046109: Add |SocketIORunnable|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1046109: Add |SocketIOEventRunnable|

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1046109: Add |SocketIOReceiveRunnable|

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [05] Bug 1046109: Add |SocketIORequestClosingRunnable|

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [06] Bug 1046109: Add |SocketIODeleteInstanceRunnable|

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [07] Bug 1046109: Add |SocketIOBase|

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [08] Bug 1046109: Add |SocketIOTask|

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [09] Bug 1046109: Add |SocketIOSendTask|

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [10] Bug 1046109: Add |SocketIOShutdownTask|

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [11] Bug 1046109: Cleanup |UnixSocketImpl|

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

These patches are only about refactoring and cleaning up. The related Bluetooth patches are attached to bug 992206.

Comment 13

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Everything looks good, hopefully that'll make debugging easier too. Wondering if we might be able to set up gtest for this module soon.

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks for the review.

https://hg.mozilla.org/integration/b2g-inbound/rev/56a5acbceadb
https://hg.mozilla.org/integration/b2g-inbound/rev/ddb118aa2648
https://hg.mozilla.org/integration/b2g-inbound/rev/3b3966a2b854
https://hg.mozilla.org/integration/b2g-inbound/rev/38c914d4c7a7
https://hg.mozilla.org/integration/b2g-inbound/rev/795507bd02d3
https://hg.mozilla.org/integration/b2g-inbound/rev/be0077054b48
https://hg.mozilla.org/integration/b2g-inbound/rev/0bf18526200b
https://hg.mozilla.org/integration/b2g-inbound/rev/9ef0211ae121
https://hg.mozilla.org/integration/b2g-inbound/rev/5314248e45b5
https://hg.mozilla.org/integration/b2g-inbound/rev/b20b097fde99
https://hg.mozilla.org/integration/b2g-inbound/rev/452a777db125

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=452a777db125

Comment 15

[Carsten Book [:Tomcat]]

sorry had to backout this changes for bustages like https://tbpl.mozilla.org/php/getParsedLog.php?id=44951714&tree=B2g-Inbound

Comment 16

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [07] Bug 1046109: Add |SocketIOBase| (v2)

Changes since v1:

  - added missing include statements

Comment 17

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Next try :) This time, I built the patch set on ICS, JB, and KK.

https://hg.mozilla.org/integration/b2g-inbound/rev/d8fa0642e550
https://hg.mozilla.org/integration/b2g-inbound/rev/9ea8e8ebfd7b
https://hg.mozilla.org/integration/b2g-inbound/rev/262d5ac31831
https://hg.mozilla.org/integration/b2g-inbound/rev/1e632c606f68
https://hg.mozilla.org/integration/b2g-inbound/rev/f031c9c5bc3b
https://hg.mozilla.org/integration/b2g-inbound/rev/a249d4a00721
https://hg.mozilla.org/integration/b2g-inbound/rev/92b5012bc456
https://hg.mozilla.org/integration/b2g-inbound/rev/2dba8a3a33b3
https://hg.mozilla.org/integration/b2g-inbound/rev/dce83909b63d
https://hg.mozilla.org/integration/b2g-inbound/rev/368f10768109
https://hg.mozilla.org/integration/b2g-inbound/rev/4e6948a0b929

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=4e6948a0b929

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8fa0642e550
https://hg.mozilla.org/mozilla-central/rev/9ea8e8ebfd7b
https://hg.mozilla.org/mozilla-central/rev/262d5ac31831
https://hg.mozilla.org/mozilla-central/rev/1e632c606f68
https://hg.mozilla.org/mozilla-central/rev/f031c9c5bc3b
https://hg.mozilla.org/mozilla-central/rev/a249d4a00721
https://hg.mozilla.org/mozilla-central/rev/92b5012bc456
https://hg.mozilla.org/mozilla-central/rev/2dba8a3a33b3
https://hg.mozilla.org/mozilla-central/rev/dce83909b63d
https://hg.mozilla.org/mozilla-central/rev/368f10768109
https://hg.mozilla.org/mozilla-central/rev/4e6948a0b929