Closed Bug 1046142 Opened 6 years ago Closed 6 years ago

Empty language to translate to drop down on localized builds

Categories

(Firefox :: Translation, defect)

defect
Not set
normal
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox31 --- unaffected
firefox32 --- verified
firefox33 --- verified
firefox34 --- verified
firefox-esr24 --- unaffected
firefox-esr31 --- unaffected

People

(Reporter: bogdan_maris, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR:
1. Open Firefox 32beta2 Turkish build (or latest Aurora Turkish)
2. Visit http://www.microsoft.com/en-us/translator/
3. Hit the equivalent of Translate in Turkish (green button)

Expected result: The language to translate to drop down has a language set.

Actual result: The language to translate to drop down is empty.

Notes:
1. This issue is reproducible on all platforms.
Flags: firefox-backlog+
This is a regression from bug 1022413 where we updated the list of target languages to make sense for a German audience.
Blocks: 1022413
Keywords: regression
Attached patch PatchSplinter Review
We need to add  "pl", "tr", "vi" to the list of supported target languages but I'm not sure if we want to also add them to the list of supported source languages.

https://bugzilla.mozilla.org/show_bug.cgi?id=1022413#c4 (which was the summary of a meeting between Felipe and Chad) says "- the list of supported target languages should mirror the list of source languages" but I don't know the rationale for that.

(Felipe Gomes from bug 1022413 comment #5)
> I sorted the listed alphabetically in German. I'll open a bug about sorting
> it alphabetically in the browser's locale.

We can't do that hardcoded sorting anymore now that we support multiple locales, so I added the sorting in this patch. AFAIK the follow-up mentioned in that comment was never filed.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8465647 - Flags: review?(mdeboer)
Added to Iteration 34.1  Florian, can you provide a point value and mark the bug as either [qa+] or [qa-] for verification.
Iteration: --- → 34.1
QA Whiteboard: [qa?]
Flags: needinfo?(florian)
Comment on attachment 8465647 [details] [diff] [review]
Patch

Please get this on beta ASAP.
Attachment #8465647 - Flags: review?(mdeboer)
Attachment #8465647 - Flags: review+
Attachment #8465647 - Flags: approval-mozilla-beta+
Attachment #8465647 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-beta/rev/c381e6fba574
Points: --- → 3
QA Whiteboard: [qa?] → [qa+]
Flags: needinfo?(florian)
(In reply to Wes Kocher (:KWierso) from comment #6)
> Backed out from beta in
> https://hg.mozilla.org/releases/mozilla-beta/rev/2d266c52e2a5 for bc1
> failures:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=45000110&tree=Mozilla-Beta

Sorry, I removed a line by accident while unbitrotting the patch for beta :-(.

Relanded:
https://hg.mozilla.org/releases/mozilla-beta/rev/33eea1df6465
Flags: needinfo?(florian)
Verified as fixed on Windows 7 64bit, Ubuntu 13.04 64bit and Mac OS X 10.9.4 using Firefox 32 beta 3.
https://hg.mozilla.org/mozilla-central/rev/e6cd9731c679
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
I tested on all platforms for latest Nightly and Aurora:

Ubuntu: Nightly (tr, pl, vi) - Verified Fixed
	Aurora (tr, pl, vi) - Verified Fixed
Mac OS X: Nightly vi - Verified Fixed; (tr, pl) - not updated to build after the fix (still 2014-08-01)
	Aurora (tr, pl, vi) - Verified Fixed
Windows: Nightly (tr, pl, vi) - Verified Fixed
	Aurora (tr, pl, vi) - Verified Fixed

Based on my testing I will go and mark this as verified as fixed.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.